Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: 404 link: docker icc canonical info is gone. #1379

Closed
gcb opened this issue Apr 12, 2024 · 8 comments
Closed

bug: 404 link: docker icc canonical info is gone. #1379

gcb opened this issue Apr 12, 2024 · 8 comments

Comments

@gcb
Copy link

gcb commented Apr 12, 2024

https://cheatsheetseries.owasp.org/cheatsheets/Docker_Security_Cheat_Sheet.html#rule-5-be-mindful-of-inter-container-connectivity contains:

For detailed guidance on configuring Docker networks for container communication, refer to the [Docker Documentation](https://docs.docker.com/network/#communication-between-containers).

That link resolves to a new content. The original target, and its content (any information about icc flag) is nowhere to be found.

@szh
Copy link
Collaborator

szh commented Apr 12, 2024

Looks like it's now in https://docs.docker.com/network/drivers/bridge/ under com.docker.network.bridge.enable_icc

@mackowski
Copy link
Collaborator

@gcb or @szh do you want to make a PR?

@gcb
Copy link
Author

gcb commented Apr 24, 2024

that page doesn't have the missing section anchor, or go into detail about icc flag like the old link. I think the old docker documentation pages are saved somewhere ... moby ones also are missing that section https://github.com/moby/moby/blob/master/libnetwork/docs/network.md

I don't know what I am expecting. But i hoped the original pointed to a page that didn't simply says:

What's really happening?

When you create or remove a user-defined bridge ... Docker uses tools specific to the operating system ... (such as adding or removing bridge devices or configuring iptables rules on Linux). These details should be considered implementation details. Let Docker manage your user-defined networks for you.

like the current ones do.

@Jeymz
Copy link
Contributor

Jeymz commented Aug 7, 2024

I believe this was resolved in PR #1350

@szh
Copy link
Collaborator

szh commented Aug 8, 2024

@Jeymz I don't see much in that PR regarding the specific icc flag this issue is discussing

@Jeymz
Copy link
Contributor

Jeymz commented Aug 8, 2024

So I think the icc flag is a bit of a miss. Looking through the wayback machine I'm having a tough time finding when it did exist. I went pretty far back, and there are tons of snapshots for this page. If you want to take a look the pages are archived here. I did find some information about this on some random site through a google search, but not sure how relevant or accurate it is link here then search for ICC.

@szh
Copy link
Collaborator

szh commented Aug 8, 2024

OK. I'm going to close this for now, @gcb please reopen and comment if you disagree.

@szh szh closed this as completed Aug 8, 2024
@gcb
Copy link
Author

gcb commented Aug 8, 2024

agree. thanks for investigating. I host a mirror of the docker docs from before the huge 'docker for desktop' split on https://gcbw.github.io/docker.github.io/network/ and also couldn't find anything after I looked there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants