Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Forgot Password #1538

Closed
gl4nce opened this issue Nov 9, 2024 · 11 comments
Closed

Update: Forgot Password #1538

gl4nce opened this issue Nov 9, 2024 · 11 comments
Assignees
Labels
ACK_OBTAINED Issue acknowledged from core team so work can be done to fix it. UPDATE_CS Issue about the update/refactoring of a existing cheat sheet.

Comments

@gl4nce
Copy link
Contributor

gl4nce commented Nov 9, 2024

What is missing or needs to be updated?

The section Offline Methods contains wrong information. The real-world examples are all leading to backup codes in connection with MFA, which is out of scope of this CS.

How should this be resolved?

The Section should be removed. AFAIK, there is no secure offline method for account recovery. Instead of removing it, this could be clearly stated there.

@gl4nce gl4nce added ACK_WAITING Issue waiting acknowledgement from core team before to start the work to fix it. HELP_WANTED Issue for which help is wanted to do the job. UPDATE_CS Issue about the update/refactoring of a existing cheat sheet. labels Nov 9, 2024
@mackowski
Copy link
Collaborator

Backup Codes are listed and described as example of Offline Methods https://cheatsheetseries.owasp.org/cheatsheets/Forgot_Password_Cheat_Sheet.html#backup-codes.
I think that we should not remove it but improve. @jmanico what do you think?

@jmanico
Copy link
Member

jmanico commented Nov 15, 2024

That works for me @mackowski - backup-codes and MFA are a legitimate part of forgot passwords flows and I want to get this right :)

@gl4nce
Copy link
Contributor Author

gl4nce commented Nov 15, 2024

In this CS, MFA is mixed up with backup codes and all examples refer to MFA. If you want to talk about MFA recovering, that should be stated clear and not mixed up with best practice forgotten password methods without MFA.

Do you have any real world example for an application with offline backup codes without MFA?

@jmanico
Copy link
Member

jmanico commented Nov 15, 2024

Yea, I have used backup codes to reset MFA when I lost the MFA device or similar.

@gl4nce
Copy link
Contributor Author

gl4nce commented Nov 15, 2024

Hehe yes, I know that method for sure. But this CS is NOT about MFA. I've never heard or seen any real world application using backup codes for just recovering the password (without MFA).

MFA recovering with offline backup codes should be stated in the corresponding CS: https://cheatsheetseries.owasp.org/cheatsheets/Multifactor_Authentication_Cheat_Sheet.html

@jmanico
Copy link
Member

jmanico commented Nov 15, 2024

I get your point. But since backup codes could be used for MFA recovery, they seem just as strong as MFA itself, if not stronger... For example you can use backup codes to sign in to your Google account if you've forgotten your password.

@gl4nce
Copy link
Contributor Author

gl4nce commented Nov 15, 2024

100% agree.

My intention for this issue is to make it clear that this section is related to MFA and has nothing to do with default password recovery methods without of MFA. Alternatively, the section can be removed completely because MFA is out of scope of that CS.

That's all.

@mackowski
Copy link
Collaborator

@gl4nce can you make a PR for this change. I think that we should clarify that. We should remove that section and replace it with link to the Multifactor Authentication Cheat Sheet to the 'Resetting MFA' section.

@gl4nce
Copy link
Contributor Author

gl4nce commented Nov 19, 2024

@mackowski PR for removing the Backup Codes subsection? If this is accepted, I can do that, of course.

@mackowski
Copy link
Collaborator

Yes, I think it would be best if we remove that section and replace it with link to the Multifactor Authentication Cheat Sheet to the 'Resetting MFA' section as this topics are loosely coupled and as you mentioned, in practice this is the only widespreaded and legitimate use case for an offline method. E.g. add something in lines: 'if account has MFA enabled (and we encourage you to allow that) and you are looking how to do MFA recovery here us link to advices how to design MFA recovery'

@gl4nce
Copy link
Contributor Author

gl4nce commented Dec 3, 2024

PR created: #1553

@mackowski mackowski added ACK_OBTAINED Issue acknowledged from core team so work can be done to fix it. and removed ACK_WAITING Issue waiting acknowledgement from core team before to start the work to fix it. HELP_WANTED Issue for which help is wanted to do the job. labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACK_OBTAINED Issue acknowledged from core team so work can be done to fix it. UPDATE_CS Issue about the update/refactoring of a existing cheat sheet.
Projects
None yet
Development

No branches or pull requests

3 participants