From 15903b4a2a100275a538b3b6bd64722a9c7a94d5 Mon Sep 17 00:00:00 2001
From: Michael <meeque@users.noreply.github.com>
Date: Fri, 19 Apr 2024 00:13:15 +0200
Subject: [PATCH 1/4] Improve a JSP example in JavaDocs.

---
 core/src/main/java/org/owasp/encoder/Encode.java | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/core/src/main/java/org/owasp/encoder/Encode.java b/core/src/main/java/org/owasp/encoder/Encode.java
index 165635c..bbfdf53 100644
--- a/core/src/main/java/org/owasp/encoder/Encode.java
+++ b/core/src/main/java/org/owasp/encoder/Encode.java
@@ -243,7 +243,8 @@ public static void forHtmlContent(Writer out, String input)
      *
      * <b>Example JSP Usage</b>
      * <pre>
-     *     &lt;div&gt;&lt;%=Encode.forHtmlAttribute(unsafeData)%&gt;&lt;/div&gt;
+     *     &lt;div title=&quot;&lt;%=Encode.forHtmlAttribute(unsafeData)%&gt;&quot;&gt;...&lt;/div&gt;
+     *     &lt;div title=&#39;&lt;%=Encode.forHtmlAttribute(unsafeData)%&gt;&#39;&gt;...&lt;/div&gt;
      * </pre>
      *
      * <table border="0" class="memberSummary" summary="Shows the input and results of encoding">

From 0b581f8c4cdfde5b884b58718900a98f2285d7e8 Mon Sep 17 00:00:00 2001
From: Michael <meeque@users.noreply.github.com>
Date: Fri, 19 Apr 2024 00:27:09 +0200
Subject: [PATCH 2/4] Make JSP example in JavaDocs more concise.

---
 core/src/main/java/org/owasp/encoder/Encode.java | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/core/src/main/java/org/owasp/encoder/Encode.java b/core/src/main/java/org/owasp/encoder/Encode.java
index bbfdf53..24bb520 100644
--- a/core/src/main/java/org/owasp/encoder/Encode.java
+++ b/core/src/main/java/org/owasp/encoder/Encode.java
@@ -243,8 +243,7 @@ public static void forHtmlContent(Writer out, String input)
      *
      * <b>Example JSP Usage</b>
      * <pre>
-     *     &lt;div title=&quot;&lt;%=Encode.forHtmlAttribute(unsafeData)%&gt;&quot;&gt;...&lt;/div&gt;
-     *     &lt;div title=&#39;&lt;%=Encode.forHtmlAttribute(unsafeData)%&gt;&#39;&gt;...&lt;/div&gt;
+     *     &lt;input value=&quot;&lt;%=Encode.forHtml(unsafeData)%&gt;&quot; title=&#39;&lt;%=Encode.forHtml(moreUnsafeData)%&gt;&#39; /&gt;
      * </pre>
      *
      * <table border="0" class="memberSummary" summary="Shows the input and results of encoding">

From 604a78f9b926391bd3768ac4545a7c7396b90cca Mon Sep 17 00:00:00 2001
From: Michael <meeque@users.noreply.github.com>
Date: Fri, 19 Apr 2024 00:39:28 +0200
Subject: [PATCH 3/4] Be clearer about quotes in forHtmlAttribute docs.

---
 core/src/main/java/org/owasp/encoder/Encode.java | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/core/src/main/java/org/owasp/encoder/Encode.java b/core/src/main/java/org/owasp/encoder/Encode.java
index 24bb520..2f66001 100644
--- a/core/src/main/java/org/owasp/encoder/Encode.java
+++ b/core/src/main/java/org/owasp/encoder/Encode.java
@@ -276,6 +276,8 @@ public static void forHtmlContent(Writer out, String input)
      *
      * <p><b>Additional Notes</b></p>
      * <ul>
+     * <li>When using this method, the caller must provide quotes around the attribute value.</li>
+     *
      * <li>Both the single-quote character ({@code '}) and the
      * double-quote character ({@code "}) are encoded so this is safe
      * for HTML attributes with either enclosing character.</li>

From 351e999dcfe4fee38c4aa4bc584d15d3de2ccbb6 Mon Sep 17 00:00:00 2001
From: Jeremy Long <jeremy.long@gmail.com>
Date: Fri, 26 Jul 2024 06:42:49 -0400
Subject: [PATCH 4/4] docs: correct javadoc

---
 core/src/main/java/org/owasp/encoder/Encode.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/src/main/java/org/owasp/encoder/Encode.java b/core/src/main/java/org/owasp/encoder/Encode.java
index 2f66001..67972d1 100644
--- a/core/src/main/java/org/owasp/encoder/Encode.java
+++ b/core/src/main/java/org/owasp/encoder/Encode.java
@@ -243,7 +243,7 @@ public static void forHtmlContent(Writer out, String input)
      *
      * <b>Example JSP Usage</b>
      * <pre>
-     *     &lt;input value=&quot;&lt;%=Encode.forHtml(unsafeData)%&gt;&quot; title=&#39;&lt;%=Encode.forHtml(moreUnsafeData)%&gt;&#39; /&gt;
+     *     &lt;input value=&quot;&lt;%=Encode.forHtmlAttribute(unsafeData)%&gt;&quot; title=&#39;&lt;%=Encode.forHtmlAttribute(moreUnsafeData)%&gt;&#39; /&gt;
      * </pre>
      *
      * <table border="0" class="memberSummary" summary="Shows the input and results of encoding">