"Implement separate netApy and borrow costs comparison for refinance" #3971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robercano
previously approved these changes
Jun 26, 2024
piekczyk
requested changes
Jun 26, 2024
piekczyk
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the borrow rate was used to calculate the net APY for refinance positions. This pull request introduces a separate netApy field that accurately represents the net APY based on the current LTV. The borrow rate is now used solely for calculating the increase in debt over one year at the current market utilization. This change improves the accuracy of the net APY calculation and provides more meaningful information to users.