Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The typing package is only required in Python 3.5 (or lower) #15

Closed
sambles opened this issue Apr 29, 2024 · 0 comments · Fixed by #16
Closed

The typing package is only required in Python 3.5 (or lower) #15

sambles opened this issue Apr 29, 2024 · 0 comments · Fixed by #16
Assignees
Labels
bug Something isn't working

Comments

@sambles
Copy link
Contributor

sambles commented Apr 29, 2024

Issue Description

Remove typing from package requirements it's only required for Python <3.5

This can cause the following error when packages are added to the base model_worker image:

#11 0.362 Traceback (most recent call last):
#11 0.362   File "/usr/bin/pip", line 5, in <module>
#11 0.362     from pip._internal.cli.main import main
#11 0.362   File "/usr/lib/python3/dist-packages/pip/__init__.py", line 1, in <module>
#11 0.362     from typing import List, Optional
#11 0.362   File "/home/worker/.local/lib/python3.10/site-packages/typing.py", line 1359, in <module>
#11 0.362     class Callable(extra=collections_abc.Callable, metaclass=CallableMeta):
#11 0.362   File "/home/worker/.local/lib/python3.10/site-packages/typing.py", line 1007, in __new__
#11 0.362     self._abc_registry = extra._abc_registry
#11 0.362 AttributeError: type object 'Callable' has no attribute '_abc_registry'

Test that the worker requirements file no longer pulls typing once ODM is updated

@sambles sambles added the bug Something isn't working label Apr 29, 2024
@sambles sambles self-assigned this Apr 29, 2024
@sambles sambles moved this to In Progress in Oasis Dev Team Tasks Apr 29, 2024
@sambles sambles linked a pull request Apr 30, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in Oasis Dev Team Tasks Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant