Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate 'statuses' Query Parameter Support in getValidators Function #2846

Closed
2 tasks
boulder225 opened this issue Feb 1, 2024 · 3 comments
Closed
2 tasks
Assignees
Labels
protocol Protocol Team tickets

Comments

@boulder225
Copy link

boulder225 commented Feb 1, 2024

🎯 Problem to be solved

getValidators function does not fully align with the specs, as it only reads ids from the query parameters, while the spec mentions both ids and statuses. The go-eth2-client library, which we depend on, does not support statuses as a query parameter. This discrepancy could limit our validator API, potentially missing out on filtering.

🛠️ Proposed solution

  • Support go-eth2-client project by proposing a PR supporting statuses.
  • For now, have TODOs in our codebase to integrate statuses parameter support once it becomes available in the go-eth2-client library.
@github-actions github-actions bot added the protocol Protocol Team tickets label Feb 1, 2024
@pinebit
Copy link
Contributor

pinebit commented Feb 1, 2024

Confirmed with attestant: once this API gets stable and supported by various clients, we can take it into development.

@pinebit
Copy link
Contributor

pinebit commented Mar 20, 2024

This ticket is ready to go, but it requires the new version of the go-eth2-client, which is to be integrated under #2936

@pinebit
Copy link
Contributor

pinebit commented May 31, 2024

We probably don't need this.

@pinebit pinebit closed this as completed May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol Protocol Team tickets
Projects
None yet
Development

No branches or pull requests

2 participants