Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase timeout on txo spend / txo list #301

Closed
tzarebczan opened this issue Jan 27, 2021 · 6 comments
Closed

increase timeout on txo spend / txo list #301

tzarebczan opened this issue Jan 27, 2021 · 6 comments
Labels
consider soon Discuss this issue at the next planning meeting, then remove this label good first issue Good for newcomers

Comments

@tzarebczan
Copy link
Contributor

tzarebczan commented Jan 27, 2021 •
edited by anbsky
Loading

We need to increase http timeouts for JSON-RPC methods txo_spend, txo_list and transaction_list as some of them can take 5+ minutes to run.

This can be done by creating a new http client for each new query.Query to be sent.

The SDK team will look to make methods more performant.
@tzarebczan
Copy link
Contributor Author

Can we have this setp for txo spend?
A VIP creator recently ran into this problem. The txo spend took 2+ hours due to a huge history.

@tzarebczan tzarebczan added the consider soon Discuss this issue at the next planning meeting, then remove this label label Mar 12, 2021
@tzarebczan
Copy link
Contributor Author

Other creators have run into this. WhenI did some testing, it can take hours to run for really large wallets.

@anbsky anbsky added the good first issue Good for newcomers label Apr 22, 2021
@bigOconstant bigOconstant mentioned this issue Apr 25, 2021
Merged
@bigOconstant
Copy link

bigOconstant commented Apr 25, 2021 •
edited
Loading

Pull request for this change.

#325

@anbsky
Copy link
Collaborator

anbsky commented Apr 26, 2021

Done, thank you @camccar

@anbsky anbsky closed this as completed Apr 26, 2021
@anbsky anbsky reopened this Apr 27, 2021
@anbsky
Copy link
Collaborator

anbsky commented Apr 27, 2021

sorry @camccar, it slipped my attention that we were fixing the wrong timeout, http.Client.Transport.ResponseHeaderTimeout was the one to fix. I also added a test for it, in case you are curious.

@anbsky anbsky closed this as completed Apr 27, 2021
@bigOconstant
Copy link

sorry @camccar, it slipped my attention that we were fixing the wrong timeout, http.Client.Transport.ResponseHeaderTimeout was the one to fix. I also added a test for it, in case you are curious.

TestCaller_timeouts, That is a really cool unit test .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
consider soon Discuss this issue at the next planning meeting, then remove this label good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@anbsky @bigOconstant @tzarebczan