Fix infinite gas cap for eth_estimateGas

[ramtandukar-wm]

System information

nitro version: Version: v3.4.0-d896e9c, time: 2025-01-14T18:03:37-05:00
go-ethereum @ 779b669

OS & Version: Linux

Expected behaviour

When --execution.rpc.gas-cap=0 is specified, calling eth_estimateGas should apply the infinite gas cap.

Actual behaviour

When calling eth_estimateGas, we receive the following error:

{'code': -32000, 'message': 'gas required exceeds allowance (14537)'}

I note, the following fix:

#396

Perhaps this also needs to be updated in

go-ethereum/internal/ethapi/api.go

Line 1307 in 8070936

postingGas, err := core.RPCPostingGasHook(call, header, state)

Not 100% sure though.

Steps to reproduce the behaviour

Backtrace

[backtrace]

When submitting logs: please submit them as text and not screenshots.

[eljobe]

@ramtandukar-wm, thanks for the bug report. Could you also post the RPC call that you used to trigger this error?

[ramtandukar-wm]

{'id': 3589729, 'jsonrpc': '2.0', 'method': 'eth_estimateGas', 'params': [{'from': '0xXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX', 'to': '0xXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX', 'data': '0x35c911330000170000000000000000174959df9e00000000000000000000000001000000', 'gas': '0xee6b280'}]} {"jsonrpc":"2.0","id":3589729,"error":{"code":-32000,"message":"gas required exceeds allowance (63940)"}}

[ramtandukar-wm]

Ofcourse this is set --execution.rpc.tx-fee-cap=0 when this call is made

[ramtandukar-wm]

I think @joshuacolvin0 may have fixed this issue now in master. I will check in a subsequent release.

[joshuacolvin0]

This has been resolved with Nitro v3.5.0 release