Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test scripts are not removed from package.json in custom function projects #375

Open
Rick-Kirkham opened this issue Jun 29, 2023 · 1 comment

Comments

@Rick-Kirkham
Copy link
Contributor

Prerequisites

Please answer the following questions before submitting an issue.
YOU MAY DELETE THE PREREQUISITES SECTION.

  • [x ] I am running the latest version of Node and the tools
  • [x ] I checked the documentation and found no answer
  • [ x] I checked to make sure that this issue has not already been filed

Expected behavior

The test:e2e and test:unit scripts would not be in the package.json of custom function projects.

Current behavior

The test:e2e and test:unit scripts ARE in the package.json of custom function projects. They do not work. Try to run them and you get an error saying that "mocha" is not a recognized command.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Create project with yo office.
  2. Choose either of the custom function project types.
  3. Let the project be created.
  4. Open the package.json.
  5. The two test scripts are still in it.

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

  • Operating System: Win11
  • Node version: 16.13.1
  • Office version:
  • Tool version: latest, just installed

Failure Logs

Please include any relevant log snippets, screenshots or code samples here.

@millerds millerds transferred this issue from OfficeDev/generator-office Jul 10, 2023
@ghost ghost added the Needs: triage 🔍 New issue, needs PM on rotation to triage ASAP label Jul 10, 2023
@millerds
Copy link
Contributor

This is handled by the convertToSingleHost script inside the template repo and not the central generator-office code.

@yjoshi-msft yjoshi-msft removed the Needs: triage 🔍 New issue, needs PM on rotation to triage ASAP label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants