Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Excel] (keyboard shortcuts) Document support in the unified app manifest #4678

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

samantharamon
Copy link
Contributor

Copy link
Contributor

Learn Build status updates of commit 2f38af1:

✅ Validation status: passed

File Status Preview URL Details
.openpublishing.redirection.json ✅Succeeded View
docs/design/keyboard-shortcuts.md ✅Succeeded View
docs/develop/extended-overrides.md ✅Succeeded n/a (file deleted or renamed)
docs/develop/json-manifest-overview.md ✅Succeeded View
docs/develop/localization.md ✅Succeeded View
docs/develop/requirements-property-unified-manifest.md ✅Succeeded View
docs/develop/unified-manifest-overview.md ✅Succeeded View
docs/includes/keyboard-shortcuts-prerequisites.md ✅Succeeded n/a (file deleted or renamed)
docs/toc.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

docs/design/keyboard-shortcuts.md Outdated Show resolved Hide resolved
docs/design/keyboard-shortcuts.md Outdated Show resolved Hide resolved
docs/design/keyboard-shortcuts.md Outdated Show resolved Hide resolved
docs/design/keyboard-shortcuts.md Outdated Show resolved Hide resolved
- On macOS, the Alt key is mapped to the Option key. On Windows, the Command key is mapped to the Ctrl key.
- The Shift key can't be used as the only modifier key. It must be combined with either Alt/Option or Ctrl/Command.
- Key combinations can include characters "A-Z", "a-z", "0-9", and the punctuation marks "-", "_", and "+". By convention, lowercase letters aren't used in keyboard shortcuts.
- When two characters are linked to the same physical key on a standard keyboard, then they're synonyms in a custom keyboard shortcut. For example, Alt+a and Alt+A are the same shortcut, as well as Ctrl+- and Ctrl+\_ ("-" and "_" are the linked to the same physical key).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the \ in Ctrl+\_ a typo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It's needed to escape the underscore.

docs/design/keyboard-shortcuts.md Outdated Show resolved Hide resolved
docs/design/keyboard-shortcuts.md Outdated Show resolved Hide resolved
Co-authored-by: Rick Kirkham <Rick-Kirkham@users.noreply.github.com>
Copy link
Contributor

Learn Build status updates of commit 47170b9:

✅ Validation status: passed

File Status Preview URL Details
.openpublishing.redirection.json ✅Succeeded View
docs/design/keyboard-shortcuts.md ✅Succeeded View
docs/develop/extended-overrides.md ✅Succeeded n/a (file deleted or renamed)
docs/develop/json-manifest-overview.md ✅Succeeded View
docs/develop/localization.md ✅Succeeded View
docs/develop/requirements-property-unified-manifest.md ✅Succeeded View
docs/develop/unified-manifest-overview.md ✅Succeeded View
docs/includes/keyboard-shortcuts-prerequisites.md ✅Succeeded n/a (file deleted or renamed)
docs/toc.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit d2750c8:

✅ Validation status: passed

File Status Preview URL Details
.openpublishing.redirection.json ✅Succeeded View
docs/design/keyboard-shortcuts.md ✅Succeeded View
docs/develop/extended-overrides.md ✅Succeeded n/a (file deleted or renamed)
docs/develop/json-manifest-overview.md ✅Succeeded View
docs/develop/localization.md ✅Succeeded View
docs/develop/requirements-property-unified-manifest.md ✅Succeeded View
docs/develop/unified-manifest-overview.md ✅Succeeded View
docs/includes/keyboard-shortcuts-prerequisites.md ✅Succeeded n/a (file deleted or renamed)
docs/toc.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 51980b3:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error: CannotMergeCommit] Cannot merge commit 51980b3db132c745d20caf32335e0bffce845303 in branch samramon-keyboard-shortcuts-unified-manifest of repository https://github.com/OfficeDev/office-js-docs-pr into branch main (commit 2fbdafa22c9ffce9210b57eb9f8cd335972a18e8). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@samantharamon samantharamon marked this pull request as ready for review October 10, 2024 02:56
Copy link
Contributor

Learn Build status updates of commit dbb896b:

✅ Validation status: passed

File Status Preview URL Details
.openpublishing.redirection.json ✅Succeeded View
docs/design/keyboard-shortcuts.md ✅Succeeded View
docs/develop/extended-overrides.md ✅Succeeded n/a (file deleted or renamed)
docs/develop/json-manifest-overview.md ✅Succeeded View
docs/develop/localization.md ✅Succeeded View
docs/develop/requirements-property-unified-manifest.md ✅Succeeded View
docs/develop/unified-manifest-overview.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 0d49f54:

✅ Validation status: passed

File Status Preview URL Details
.openpublishing.redirection.json ✅Succeeded View
docs/design/keyboard-shortcuts.md ✅Succeeded View
docs/develop/extended-overrides.md ✅Succeeded n/a (file deleted or renamed)
docs/develop/json-manifest-overview.md ✅Succeeded View
docs/develop/localization.md ✅Succeeded View
docs/develop/requirements-property-unified-manifest.md ✅Succeeded View
docs/develop/unified-manifest-overview.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants