Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video is still playing but hidden when a new video is previewed #3

Closed
some1so opened this issue Dec 28, 2024 · 9 comments
Closed

Video is still playing but hidden when a new video is previewed #3

some1so opened this issue Dec 28, 2024 · 9 comments
Assignees

Comments

@some1so
Copy link

some1so commented Dec 28, 2024

This is great, thanks!
I'm using the Autoplay version, and I found one issue.
I select a webm, hit spacebar, and it previews with sound playing, works fine.
While it's playing, select a second webm with arrow keys or pointer, the first one will hide but the sound will keep playing, and the second webm will load and play with sound.
If I pick another webm, the first one will stop, the second will hide and keep playing, and the third will play normally.
Closing the QL window will stop everything.
I'm on 15.2, Intel Macbook Pro.
Thanks again

@Oil3 Oil3 self-assigned this Dec 28, 2024
@Oil3
Copy link
Owner

Oil3 commented Jan 1, 2025

HI @some1so , thanks for the precise bug report!

I fixed it on my side, let me know if it works for you, make sure to delete the previous version.
https://github.com/Oil3/Webm-QuickLook-Plug-In/releases/tag/WebmQuicklook-2025jan-backgroundplayfixed-autoplay

@some1so
Copy link
Author

some1so commented Jan 4, 2025

Thank you for the fix!
I tested it, but unfortunately found an issue when I play a webm that has been previously been played.
It looks complicated in the repro steps, but essentially it is just that the previous webm is retaining it's state when hidden, and if played again will just display in that same state.
It's a small thing, and only shows up when aggressively clicking or arrowing back and forth in the list, and it sorts itself out with a few clicks, but I thought you'd want to know :)
Repro steps:
Play webm 1 - plays fine.
While webm 1 is still playing, play webm 2. Webm 1 stops, webm 2 plays fine.
While webm 2 is still playing, play webm 1 again. Webm 2 hides but continues to play. Webm 1 is displayed, but paused at the time that the switch happened.
Play webm 2 again, and it displays while still playing.
Play webm 1 again, and it is still paused while webm 2 continues to play.
Play webm 3, and webm 2 stops playing, webm 1 is hidden, and webm 3 plays fine.
Play webm 1 again, still paused, webm 3 is hidden but continues to play.
Play webm 3 again, it displays and continues playing while webm 1 is hidden.
Play webm 4, it plays fine while webm 3 is hidden and paused.
Play webm 1 again, it now plays fine while webm 4 is hidden and paused.

Thanks

@Oil3
Copy link
Owner

Oil3 commented Jan 12, 2025

It's taking more than time than expected,
I'v spent quite some time trying to fix it and it's quite a mess,
the closest I got so far was to fixing this issue is strictly when the finder is itself with the side preview.
Alternatively, without autoplay worked too, but I understand it's not the same.
There is one workaround possible, but I first want to try something very simple: either I find out how to have the panel trigger pause on arrow key (that does work in the 'app' of the plugin, but in preview it doesn't -extensions are quite sandboxed.
So the idea now is to find out which 'NSEventmask' we could use to trigger the pause.
Pausing is easy, but pausing the hidden one pauses the frontmost one too.
And every conventional pauseallmedias, closeallmedia, reload etc don't work.
All this to say, I'm on it.

Apart of this, all good? Always snappy, no crash?

@some1so
Copy link
Author

some1so commented Jan 12, 2025

Hi
Yes, it's very usable and I haven't seen other problems with it. If the pause problem shows up I just clear it by going up or down a couple of webms in the list and it works fine. So no need to rush or feel pressure to get a fix out quickly :)

@Oil3

This comment has been minimized.

@Oil3
Copy link
Owner

Oil3 commented Feb 6, 2025

@some1so Hi, fixed now, let me know if it works as intended for you as well,

direct-download: https://github.com/Oil3/Webm-QuickLook-Plug-In/releases/download/webM-feb2025/Webm.Quicklook.feb2025.universal.binary.zip

@some1so
Copy link
Author

some1so commented Feb 8, 2025

Hi
I installed the new version, and it works great, except for the pause issue, which still happens when reversing :)
But, it's easy to clear it, and not a big problem, so it's great, and much better than other options.
Thanks for your attention and efforts, I understand it's a pretty restrictive environment to code in. I'll go ahead and close this now as I am happy with it.
Thanks

@some1so some1so closed this as completed Feb 8, 2025
@Oil3
Copy link
Owner

Oil3 commented Feb 21, 2025

@some1so Last check: you did replace at same location or delete the previous version? I don't have the bug on neither of my machine, i.e. going through a list of videos never has the previous video continuing playback while hidden;
in all cases, thank you for your reports, it brought many improvements!

@some1so
Copy link
Author

some1so commented Feb 22, 2025

Hi
I just deleted and reinstalled it to make sure.
I don't get the "hidden and still playing" problem anymore. I get the Pause issue - when I go back to a video that was previously playing, it is paused where it was before -
play vid 1, after a couple of seconds arrow down to play vid 2. Let it play a couple of seconds and arrow up to vid 1 again. Vid 1 is paused where it was when I left it, and doesn't restart from beginning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants