Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023.01.10 update: code below can deteriorate model performance #80

Open
Dannynis opened this issue May 27, 2023 · 3 comments
Open

2023.01.10 update: code below can deteriorate model performance #80

Dannynis opened this issue May 27, 2023 · 3 comments

Comments

@Dannynis
Copy link

Hey,
by commenting the code in data_utils.py you introduced a potential bug if the wav files are not equality sized

@skol101
Copy link

skol101 commented May 29, 2023

Could you provide link to what code exactly ?

@Dannynis
Copy link
Author

when commenting this code:
'''
lmin = min(c.size(-1), spec.size(-1))
spec, c = spec[:, :lmin], c[:, :lmin]
audio_norm = audio_norm[:, :lminself.hop_length]
_spec, _c, _audio_norm = spec, c, audio_norm
while spec.size(-1) < self.spec_len:
spec = torch.cat((spec, _spec), -1)
c = torch.cat((c, _c), -1)
audio_norm = torch.cat((audio_norm, _audio_norm), -1)
start = random.randint(0, spec.size(-1) - self.spec_len)
end = start + self.spec_len
spec = spec[:, start:end]
c = c[:, start:end]
audio_norm = audio_norm[:, start
self.hop_length:end*self.hop_length]
'''

@skol101
Copy link

skol101 commented Jun 1, 2023

So, you're saying this code must be UNcommented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants