-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show external packages #8
Comments
That feature is out of scope for lakos. For external dependencies, please try |
Do you happen to know of any tools that allow us to see which files are importing which external packages? |
Hi @lukepighetti, lakos parses all imports in the getEgdes function, but then I filter out the external imports on this line. You can try commenting out that line and see if that does what you want. The reason I keep only the internal imports is that external imports make the graph ugly and also should not be counted in the metrics. Maybe in the future, I'll consider keeping external imports but marking them in a different color and not counting them in the metrics. |
Seems like a feature that would be easy to add with a CLI flag. I'm pulling the data into a pandas dataframe anyway, and building my own graphs. |
Hi @lukepighetti, to clarify, you want to show just top-level external imports, without recursively following all external imports, and without counting external files in the metrics. Is this correct? |
If a file is a node, some metadata on the node that states which external packages it imported would be fine. Or it could be blended into the graph somehow, but I'm not sure what that would look like. |
That sounds doable 😊 I'll consider adding that to the json output in the next release. If I were to graph it, the external files would be floating outside the project directory structure--I can try it and see if I can make it work visually. |
Would be nice if lakos had an option to also quantify which files/projects are importing external dependencies
The text was updated successfully, but these errors were encountered: