Add default completion commit characters #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrieken
reviewed
May 19, 2017
| ' ', '{', '}', '[', ']', '(', ')', '.', ',', ':', | ||
| ';', '+', '-', '*', '/', '%', '&', '|', '^', '!', | ||
| '~', '=', '<', '>', '?', '@', '#', '\'', '\"', '\\']; | ||
|
|
There was a problem hiding this comment.
That is one long list 😄 Unsure if all commit characters make sense on all completion item kinds but the API is used as indented.
There was a problem hiding this comment.
Those are precisely the characters we commit on in Visual Studio. 😄
There was a problem hiding this comment.
Note that there are cases where we tweak the list for various commit characters for some items, but this matches 99.9% of them.
|
@filipw: Do you want to take a look? |
filipw
approved these changes
May 19, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1491 and #1487