Unable to report a Stop Problem

[mds08011]

Summary:

I tried to report an issue with a bus stop via the "Stop Problem" feedback channel but got a vague "unable to send" failure message.

Steps to reproduce:

1. In the app, select "Send Feedback" and then "Report a Stop Problem".
2. Fill in the "Address of problem" and "problem description" fields.
3. Select "something else" in the "choose a problem" field
4. Submit the stop problem.
5. Try to resubmit upon failure.

Expected behavior:

I expected the app to submit my issue.

Observed behavior:

I message reading "Unable to send the report. Try again?" appears. The report fails to send upon retry.

Device and Android version:

App Version: 2.8.0
Model: Pixel 2
OS Version: 11 / 30
Google Play Services App: 20.42.17 (150400-342117392)
Google Play Services Library: 12451000
Region/API: San Diego (selected automatically)

Screenshots:

[mds08011]

I am suspicious but have not confirmed that the amount of text/characters played a role. This is the text I entered in the "problem description" field if it is useful for reproducing:

A San Diego MTS bus stop was previously removed (mid-2019?) but the stop still shows in OneBusAway. The stop is shown in the main map, trip/route progress, and selecting the stop shows ETAs for buses that will not actually be stopping. Google Maps also show this erroneous stop, so perhaps the issue is stemming from GTFS data? I can confirm that on November 18, 2020 there are no poles, signs, or anything else at the location shown on the map.

Stop number: 99191
Stop Location: Viewridge Avenue and Balboa Avenue (East Bound)
Bus Route: 60

[barbeau]

@mds08011 Thanks for the great report! I'll take a look.

[amrhossamdev]

I can confirm it's about the length of the user comment, after investigating with a word count exceeding around ~ 50 words it fails

response code: 500 (Internal Server Error)
error message: Json Error

Request URL: https://buseta.wmata.com/onebusaway-api-webapp/api/where/report-problem-with-stop.json?stopId=1_2917&code=other&data=%7B%22code%22%3A%22other%22%7D&userComment=Test%20test%20test%20Test%20test%20Test%20test%20test%20Test%20test%20test%20Test%20test%20Test%20test%20test%20Test%20test%20test%20Test%20test%20Test%20test%20test%20Test%20test%20test%20Test%20test%20Test%20test%20Test%20test%20test%20Test%20test%20Test%20test%20test%20Test%20test%20test%20Test%20test%20Test%20test%20test%20Test%20test%20test%20Test%20test%20Test%20test%20test%20Test%20test%20test%20Test%20test%20Test%20test%20test%20%20&userLat=31.046550000000003&userLon=30.470485&userLocationAccuracy=3&app_ver=136&app_uid=3bbae3a6-1467-4af2-bfe4-d71ce94b187c&version=2&key=v1_BktoDJ2gJlu6nLM6LsT9H8IUbWc%3DcGF1bGN3YXR0c0BnbWFpbC5jb20%3D

HTTP servers and clients often have limits on the maximum length of URLs they can handle. This limit can vary depending on the server software, and configuration.

To resolve this issue, we can consider sending large amounts of data, such as lengthy comments, in the request body instead of appending them directly to the URL.

I can work on this issue with the backend team @aaronbrethorst

[amrhossamdev]

After investigating the API and running the server in my machine using docker I tried to send userComment in the body instead of in the parameters, using POST but I got a null response, after checking the database table using SELECT * FROM oba_stop_problem_reports;

the comment was sent and saved in the database but I got null in the response, i know maybe the API is not ready for receiving the user comment in the body but it's actually received it but I got wrong response, to fix this issue we need to modify the API to allow getting a successful message

1: First the table of reports is empty

2: I will make a request but i will send user comment in the body

3: Checking the table again

The request is successful but we are receiving a wrong response, fixing the API to allow receiving userComment in the body will fix the issue & it will require editing the request in the Android also.

@aaronbrethorst