Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trip status header fills entire screen if route name is long #899

Closed
barbeau opened this issue Jul 6, 2018 · 2 comments
Closed

Trip status header fills entire screen if route name is long #899

barbeau opened this issue Jul 6, 2018 · 2 comments
Assignees
Labels
Milestone

Comments

@barbeau
Copy link
Member

barbeau commented Jul 6, 2018

Summary:

Reported by a user:

It is difficult to see the stop statuses for the link light rail line since it takes up the whole screen. Whenever I look as the trip status for the Link Light Rail, it'll always look like this.

image

Steps to reproduce:

  1. Go to Puget Sound region
  2. Search for route "link light rail"
  3. Tap on arrival time for stop that includes "Link light rail" trip/route and choose "Show trip status"

Expected behavior:

Header should be limited to a fixed size even though "Link light rail" route name is huge

Observed behavior:

Header expands to completely fill the screen, hiding the status

Device and Android version:

App Version: 2.3.8
Model: SM-G930T (Samsung Galaxy S7)
OS Version: 7.0 / 24
Google Play Services App: 12.6.85 (040408-197041431)
Google Play Services Library: 11910000
Region/API: Puget Sound (selected automatically)

@barbeau barbeau added the bug label Jul 6, 2018
@barbeau barbeau added this to the v2.3.x milestone Jul 6, 2018
@barbeau barbeau self-assigned this Jul 6, 2018
@barbeau
Copy link
Member Author

barbeau commented Jul 6, 2018

I can reproduce this on a Samsung Galaxy S8 emulator config, but only after increasing font size from normal to large:

image

@barbeau
Copy link
Member Author

barbeau commented Jul 6, 2018

Here's what it looks like after limiting the TextView size for the route short name to 6 letters max, and max of 1 line, which is the same limit we use for the Nearby Route mode header:

                android:maxLength="6"
                android:maxLines="1"

image

@barbeau barbeau closed this as completed in 4f755f1 Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant