Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enhance project archive/unarchive functionality in controller a… #1131

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

feat: enhance project archive/unarchive functionality in controller a… #1131

wants to merge 1 commit into from

Conversation

preethamdnr
Copy link

@preethamdnr preethamdnr commented Oct 11, 2024 •
edited
Loading

  • Updated to improve the archive/unarchive process.
  • Modified to handle new routes for archiving and unarchiving projects.

Description

image

Related PRS (if any):

To test this backend PR you need to checkout the #2778 frontend PR.
…

Main changes explained:

  • Updated to improve the archive/unarchive process.
  • Modified to handle new routes for archiving and unarchiving projects.

How to test:

  1. check into current branch
  2. do npm install and npm run build and npm run start to run this PR locally
  3. Clear site data/cache
  4. further steps please follow instruction in Frontend PR.

@preethamdnr
feat: enhance project archive/unarchive functionality in controller a…
9aca87f 
…nd router

- Updated  to improve the archive/unarchive process.
- Modified  to handle new routes for archiving and unarchiving projects.
@preethamdnr preethamdnr mentioned this pull request Oct 11, 2024
Open
shivansh-nathani
shivansh-nathani approved these changes Oct 11, 2024
View reviewed changes
Copy link

@shivansh-nathani shivansh-nathani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here look good, I have reviewed the FE PR and added the necessary comments there.

@chu-ziyu chu-ziyu self-requested a review October 12, 2024 00:29
chu-ziyu
chu-ziyu approved these changes Oct 12, 2024
View reviewed changes
Copy link

@chu-ziyu chu-ziyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR in both dark and light mode, everything goes well. Screenshot attached in frontend PR.

@anirudhsk2107 anirudhsk2107 self-requested a review October 12, 2024 20:24
anirudhsk2107
anirudhsk2107 reviewed Oct 12, 2024
View reviewed changes
Copy link

@anirudhsk2107 anirudhsk2107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments on frontend PR

aaryaneil
aaryaneil approved these changes Oct 13, 2024
View reviewed changes
Copy link

@aaryaneil aaryaneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR and the changes work as expected and left a review on the frontend.

@samarth9201
Copy link
Contributor

Tested and added comments in Frontend PR

AshishNags
AshishNags approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@AshishNags AshishNags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this PR, detailed comment on the frontend PR

hqzhu0913
hqzhu0913 approved these changes Oct 23, 2024
View reviewed changes
Copy link

@hqzhu0913 hqzhu0913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review FE and BE. Both work as explained. Function well in light and black mode. Both show and hide, archive and unarchive functions work as expected. More pictures are in the front end comment.

@RashmiKY98
Copy link

When a user without the necessary permissions accesses the Project tab, a blank page currently displays. An alert box with a message such as, "Access Denied - Only users with the required permissions can access this page." will improve the user experience. This will clarify that access is restricted, rather than suggesting a website error because of the empty page.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anirudhsk2107 anirudhsk2107 anirudhsk2107 left review comments

@chu-ziyu chu-ziyu chu-ziyu approved these changes

@AshishNags AshishNags AshishNags approved these changes

@aaryaneil aaryaneil aaryaneil approved these changes

@shivansh-nathani shivansh-nathani shivansh-nathani approved these changes

@hqzhu0913 hqzhu0913 hqzhu0913 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@preethamdnr @samarth9201 @RashmiKY98 @hqzhu0913 @shivansh-nathani @aaryaneil @AshishNags @anirudhsk2107 @chu-ziyu