Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shefali unit test pie chart #2672

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Shefali unit test pie chart #2672

merged 2 commits into from
Nov 5, 2024

Conversation

SMitta11
Copy link

@SMitta11 SMitta11 commented Sep 13, 2024 •
edited
Loading

Description

Unit test for src/components/common/PieChart/PieChart.jsx

Main changes explained:

Added test cases to check for the following

  • applies dark mode class correctly
  • renders the SVG pie chart
  • generates the correct number of unique colors
  • -removes SVG on unmount

How to test:

  1. check into current branch
  2. do npm install
  3. do npm test PieChart.test.js

##Screenshot after running:
Screen Shot 2024-09-13 at 12 21 35 PM

@netlify Netlify
Copy link

netlify bot commented Sep 13, 2024 •
edited
Loading

✅ Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit c182bf9
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/66e476ce30cd900008799321
😎 Deploy Preview https://deploy-preview-2672--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

RishithaMamidala
RishithaMamidala approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@RishithaMamidala RishithaMamidala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SMitta11
Reviewed the PR, Passes all test cases.
PR 2672

ArtemisNyx3
ArtemisNyx3 approved these changes Sep 13, 2024
View reviewed changes
Copy link

@ArtemisNyx3 ArtemisNyx3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

test cases passed

nikhilpittala16
nikhilpittala16 approved these changes Sep 14, 2024
View reviewed changes
Copy link

@nikhilpittala16 nikhilpittala16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the PR and all the test cases have passed.
Screenshot (199)

Saniya98
Saniya98 approved these changes Sep 14, 2024
View reviewed changes
Copy link

@Saniya98 Saniya98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All test cases are passing
image

jinxyou
jinxyou approved these changes Sep 14, 2024
View reviewed changes
Copy link
Contributor

@jinxyou jinxyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All test cases have passed.
Screenshot 2024-09-13 234600

Abhinav-Ankur786
Abhinav-Ankur786 approved these changes Sep 14, 2024
View reviewed changes
Copy link

@Abhinav-Ankur786 Abhinav-Ankur786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test cases are passing

image

@chappdev2019
Copy link
Member

Test cases are passing!

image

Gauravmg6
Gauravmg6 approved these changes Sep 16, 2024
View reviewed changes
Copy link

@Gauravmg6 Gauravmg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the test cases are passing.

Screenshot 2024-09-16 150101

ddshah878
ddshah878 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@ddshah878 ddshah878 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the PR and all the test cases have passed. Good job!

image

vishavk1992
vishavk1992 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@vishavk1992 vishavk1992 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this PR and all test cases passed successfully

Screenshot 2024-09-17 162714

ishangoel17
ishangoel17 reviewed Sep 18, 2024
View reviewed changes
Copy link

@ishangoel17 ishangoel17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All test cases are passing. Below is the screenshot for reference:
Capture2672

Watchdog00
Watchdog00 reviewed Sep 19, 2024
View reviewed changes
Copy link

@Watchdog00 Watchdog00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the changes, and everything aligns with the PR specifications. Tests are passing.
#2672

neeharikakoniki
neeharikakoniki approved these changes Sep 19, 2024
View reviewed changes
Copy link

@neeharikakoniki neeharikakoniki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit tests thoroughly cover the core functionality of the PieChart.jsx component. The dark mode class, SVG rendering, color generation, and unmounting behavior are all well-tested.

image

@geetamatkar
Copy link

Hi @SMitta11 ,
Tested this PR and it is working as expected.

PR2672

@one-community
Copy link
Member

Thank you all, merging!

@one-community one-community merged commit 04a835a into development Nov 5, 2024
5 checks passed
@one-community one-community mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Watchdog00 Watchdog00 Watchdog00 left review comments

@ishangoel17 ishangoel17 ishangoel17 left review comments

@ddshah878 ddshah878 ddshah878 approved these changes

@vishavk1992 vishavk1992 vishavk1992 approved these changes

@nikhilpittala16 nikhilpittala16 nikhilpittala16 approved these changes

@RishithaMamidala RishithaMamidala RishithaMamidala approved these changes

@Gauravmg6 Gauravmg6 Gauravmg6 approved these changes

@Saniya98 Saniya98 Saniya98 approved these changes

@Abhinav-Ankur786 Abhinav-Ankur786 Abhinav-Ankur786 approved these changes

@neeharikakoniki neeharikakoniki neeharikakoniki approved these changes

@ArtemisNyx3 ArtemisNyx3 ArtemisNyx3 approved these changes

@jinxyou jinxyou jinxyou approved these changes

Assignees
No one assigned
Labels
Moved to Final Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.