Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anne Fixed spacing between task rows and within task rows in WBS #2709

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

Annezhang673
Copy link
Contributor

Description

Screen Shot 2024-09-21 at 7 24 23 PM

Related PRS (if any):

This frontend PR is related to the development backend PR.

Main changes explained:

  • Update HighestGoodNetworkApp/src/components/Projects/WBS/WBSDetail/wbs.css to increase the spacing betwwen sub-sub task and the spacing between line spacing of txt in WBS.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to dashboard→ Other Links>Projects>Click WBS Icon
    Please refer to the above link on how to create WBS task and sub tasks. There are minor differences.
  6. Add task A with two lines of name, then proceed to add sub task B, then proceed to add sub task C. Verify that the line spacing of task A is increased and the sub-sub task is spaced out, compared to the screenshot in the description. Watch the video below if you need an example of the tasks and sub tasks for testing.

Screenshots or videos of changes:

video1864271924.mp4

Note:

Include the information the reviewers need to know.

Copy link

netlify bot commented Sep 22, 2024

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 4be3a37
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/66ef5f8c9946ca00087cfc06
😎 Deploy Preview https://deploy-preview-2709--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Nahiyan-16 Nahiyan-16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great and visibly looks awesome.
Before:
Screenshot 2024-09-21 205134
After:
Screenshot 2024-09-21 205155

Copy link

@ArtemisNyx3 ArtemisNyx3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before
image

After
image

code is working as expected and there is a big improvement in readability, it doesn't look congested anymore.

Copy link

@sam19981 sam19981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are working as expected there is a neat space between the task and sub task.

Screenshot 2024-09-21 at 10 45 21 PM

@chappdev2019
Copy link
Member

This works great!

image

Copy link
Contributor

@abdel-lall abdel-lall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice job!
Screenshot 2024-09-22 005206

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Sep 23, 2024
Copy link

@ashmita123 ashmita123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested PR #2709. The updated task spacing in the WBS table works as expected, improving readability.

Screenshot 2024-09-23 at 1 41 17 PM

@Lexie5212 Lexie5212 self-requested a review September 24, 2024 01:09
Copy link
Contributor

@Lexie5212 Lexie5212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the PR and the code changes worked as expected. With lines and spaces, the interface view became nice.
Screenshot 2024-09-23 at 18 08 35

Copy link
Contributor

@RishithaMamidala RishithaMamidala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Annezhang673
Changes are working, there is a space between the task and sub task.
PR 2709

@anirudhsk2107 anirudhsk2107 self-requested a review September 24, 2024 03:19
Copy link

@anirudhsk2107 anirudhsk2107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it in both light and dark mode, and they worked perfectly
PR_ 2709
Screen Shot 2024-09-23 at 11 20 56 PM

Copy link
Contributor

@nikhilgiri0226 nikhilgiri0226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Changes are visible as expected.

@chu-ziyu chu-ziyu self-requested a review September 24, 2024 22:26
Copy link
Contributor

@chu-ziyu chu-ziyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this PR and everything worked as expected.

Screen.Recording.2024-09-24.at.3.26.36.PM.mov

Copy link

@mrinalini-raghavendran19 mrinalini-raghavendran19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me:

Tested it by adding subtasks to task:

Before:

Screenshot 2024-09-24 at 4 30 36 PM

After:
Screenshot 2024-09-24 at 4 31 09 PM

@saurabhshetty29
Copy link

Tested by adding sub tasks, looks good!
Screenshot 2024-09-24 at 10 14 45 PM

Copy link

@SFA23SCM35V SFA23SCM35V left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected approving the PR
PR 2709

Copy link

@nevatiarishabh nevatiarishabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the PR. Everything is working as expected. Looks good to me. The spacing has been effectively changed.

Screenshot 2024-09-25 at 1 10 15 PM

@khushijain03 khushijain03 self-requested a review September 26, 2024 01:10
Copy link

@khushijain03 khushijain03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by adding tasks and sub-tasks, changes are working as expected.
Screenshot 2024-09-25 at 9 08 46 PM

Copy link
Contributor

@vishavk1992 vishavk1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this PR and everything works great!!

Screenshot 2024-09-26 151700

@nishitag5 nishitag5 self-requested a review September 27, 2024 04:42
Copy link

@nishitag5 nishitag5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are working as expected
Before:
Screenshot 2024-09-27 002431

After:
image

Copy link

@neeharikakoniki neeharikakoniki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR successfully improves the readability of the WBS by increasing the line spacing for tasks and properly spacing sub-sub tasks. The changes are well-implemented, making the task hierarchy visually clearer and easier to navigate.

image

@Annezhang673 Annezhang673 changed the title Fixed spacing between task rows and within task rows in WBS Anne Fixed spacing between task rows and within task rows in WBS Sep 28, 2024
Copy link

@Vincent-space Vincent-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Annezhang673 , the WPS of #2709 looks great when I tried to add task.
image

Copy link
Contributor

@aaryaneil aaryaneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR and the changes work as described.
Screenshot 2024-09-28 at 10 10 35 AM

Copy link
Contributor

@jinxyou jinxyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spacing seems working well. Great work!
Screenshot 2024-09-28 164515

Copy link

@Muzammil603 Muzammil603 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
workinga as expected

@one-community
Copy link
Member

Thank you all, merging!

@one-community one-community merged commit 1b13a58 into development Sep 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.