Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sai preetham porject archive unarchive #2778

Open
wants to merge 10 commits into
base: development
Choose a base branch
from

Conversation

preethamdnr
Copy link
Contributor

@preethamdnr preethamdnr commented Oct 11, 2024

Description

image

Related PRS (if any):

This frontend PR is related to the #1131 backend PR.

Main changes explained:

  • Updated Project.jsx with archive and Unarchive button based on isArchive status
  • Updated Projects.jsx to fetch project details based on archive /unarchive status for users
  • Updated the actions in Project.js to make api call for unarchived projects.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin/owner user who has permission to see projects and archive/unarchive
  5. go to dashboard->Otherlinks->Projects
  6. Confirm Show Archived Button: First, check if the "Show Archived" button is visible on the page. If the button is visible, click on it. After clicking the "Show Archived" button, confirm whether you can see all archived projects listed on the screen.
  7. Toggle Between Archived and Unarchived Projects: After clicking the "Show Archived" button, confirm that the button label changes to "Hide Archived." Click the "Hide Archived" button and verify that it returns you to the unarchived projects list.
  8. Archiving a Project: Select any project from the unarchived projects list and archive it. After archiving the project, click on the "Show Archived" button and confirm that the newly archived project appears in the archived projects list.
  9. Unarchiving a Project: From the archived projects list, select the same project you archived in the previous step and unarchive it. Verify that after unarchiving, the project is now listed among the unarchived projects.

Screenshots or videos of changes:

video1690596935.mp4

Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 1668197
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/6748eab6d296f000080f9616
😎 Deploy Preview https://deploy-preview-2778--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@shivansh-nathani shivansh-nathani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the changes and have a few suggestions on the UI part

  1. The text search and actual search box have different heights, maybe we can add consistent heights here
  2. The term 'Hide archived' could be replaced with something better.
  3. Have consistent case for 'Archive' and 'UNARCHIVE'
Screenshot 2024-10-11 at 1 27 32 PM Screenshot 2024-10-11 at 1 27 45 PM

@chu-ziyu chu-ziyu self-requested a review October 12, 2024 00:27
chu-ziyu
chu-ziyu previously approved these changes Oct 12, 2024
Copy link
Contributor

@chu-ziyu chu-ziyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR in both dark and light mode, everything goes well.
Screenshot 2024-10-11 at 5 23 47 PM
Screenshot 2024-10-11 at 5 28 11 PM

@ShreyaLaheri
Copy link

Faced an error while fetching the archived projects
image

@anirudhsk2107 anirudhsk2107 self-requested a review October 12, 2024 20:20
Copy link

@anirudhsk2107 anirudhsk2107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting an error when i click on show archived
Screen Shot 2024-10-12 at 4 04 19 PM

Also, if i select and archive a project and then click on show archive then it shows the project i archived but still gives the same error.
But if i click on "Hide Archived" and then "Show Archived" again then the archived project disappears and just the error appears
Screen Shot 2024-10-12 at 4 19 42 PM

aaryaneil
aaryaneil previously approved these changes Oct 13, 2024
Copy link
Contributor

@aaryaneil aaryaneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR and the changes work as described. The archive button changes to hide archive when clicked and the archived project list loads properly. Also when a project is archived it shows up in the archived list a vice versa.
Screenshot 2024-10-13 at 2 57 45 AM
Screenshot 2024-10-13 at 2 57 50 AM

samarth9201
samarth9201 previously approved these changes Oct 22, 2024
Copy link
Contributor

@samarth9201 samarth9201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified and Validated the changes, everything is working as expected.

Screenshot (96)
Screenshot (97)
Screenshot (98)
Screenshot (99)
Screenshot (100)
Screenshot (101)

AshishNags
AshishNags previously approved these changes Oct 22, 2024
Copy link

@AshishNags AshishNags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this PR, changes working as expected.
Screenshot 2024-10-22 124228
Screenshot 2024-10-22 124242
Screenshot 2024-10-22 124635
Screenshot 2024-10-22 124656

hqzhu0913
hqzhu0913 previously approved these changes Oct 23, 2024
Copy link

@hqzhu0913 hqzhu0913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review FE and BE. Both work as explained. Function well in light and black mode. Both show and hide, archive and unarchive functions work as expected.
Screenshot 2024-10-23 at 3 07 58 PM
Screenshot 2024-10-23 at 3 04 48 PM
Uploading Screenshot 2024-10-23 at 3.04.28 PM.png…

Copy link

@ajitp4292 ajitp4292 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR functionality locally by clearing site data and logging in as an admin user. Verified that the "Show Archived" and "Hide Archived" buttons toggle correctly, displaying the appropriate project lists. Successfully archived and unarchived projects, ensuring they appeared in the correct lists, confirming the feature works as expected.

Screenshot 2024-10-25 at 12 24 34 PM

Copy link

@CodewithKoushica CodewithKoushica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed an issue with the UI: when clicking view archived button, it puts up an error.
Screenshot 2024-10-31 at 3 34 01 PM

@preethamdnr
Copy link
Contributor Author

I am getting an error when i click on show archived Screen Shot 2024-10-12 at 4 04 19 PM

Also, if i select and archive a project and then click on show archive then it shows the project i archived but still gives the same error. But if i click on "Hide Archived" and then "Show Archived" again then the archived project disappears and just the error appears Screen Shot 2024-10-12 at 4 19 42 PM

Hi,

Thank you for taking the time to review my PR. I noticed that the issue mentioned in the attached images occurs because the related backend PR (#1131) has not been checked in.

To ensure everything works as expected, please checkin to the branch in the PR (#1131) in you backend first, and then run this frontend PR(#2778). The two are interconnected, and this frontend PR depends on the changes made in the backend.

Thank you for your understanding and support. Let me know if you need any further clarification.

Best regards,
Sai Preetham

@preethamdnr
Copy link
Contributor Author

I am getting an error when i click on show archived Screen Shot 2024-10-12 at 4 04 19 PM

Also, if i select and archive a project and then click on show archive then it shows the project i archived but still gives the same error. But if i click on "Hide Archived" and then "Show Archived" again then the archived project disappears and just the error appears Screen Shot 2024-10-12 at 4 19 42 PM

Hi,

Thank you for taking the time to review my PR. I noticed that the issue mentioned in the attached images occurs because the related backend PR (#1131) has not been checked in.

To ensure everything works as expected, please checkin to the branch in the PR (#1131) in you backend first, and then run this frontend PR(#2778). The two are interconnected, and this frontend PR depends on the changes made in the backend.

Thank you for your understanding and support. Let me know if you need any further clarification.

Best regards,
Sai Preetham

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.