-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sai preetham porject archive unarchive #2778
base: development
Are you sure you want to change the base?
Conversation
Reafctored code related to Archive functionality from Projects to Project.
…o Project component regarding Archive functionality.
…or else raise an error. Fixes creating duplicate projects.
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am getting an error when i click on show archived
Also, if i select and archive a project and then click on show archive then it shows the project i archived but still gives the same error.
But if i click on "Hide Archived" and then "Show Archived" again then the archived project disappears and just the error appears
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the PR functionality locally by clearing site data and logging in as an admin user. Verified that the "Show Archived" and "Hide Archived" buttons toggle correctly, displaying the appropriate project lists. Successfully archived and unarchived projects, ensuring they appeared in the correct lists, confirming the feature works as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, Thank you for taking the time to review my PR. I noticed that the issue mentioned in the attached images occurs because the related backend PR (#1131) has not been checked in. To ensure everything works as expected, please checkin to the branch in the PR (#1131) in you backend first, and then run this frontend PR(#2778). The two are interconnected, and this frontend PR depends on the changes made in the backend. Thank you for your understanding and support. Let me know if you need any further clarification. Best regards, |
Hi, Thank you for taking the time to review my PR. I noticed that the issue mentioned in the attached images occurs because the related backend PR (#1131) has not been checked in. To ensure everything works as expected, please checkin to the branch in the PR (#1131) in you backend first, and then run this frontend PR(#2778). The two are interconnected, and this frontend PR depends on the changes made in the backend. Thank you for your understanding and support. Let me know if you need any further clarification. Best regards, |
1668197
Description
Related PRS (if any):
This frontend PR is related to the #1131 backend PR.
…
Main changes explained:
…
How to test:
npm install
and...
to run this PR locallyScreenshots or videos of changes:
video1690596935.mp4