Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajay - Fix Project WBS list and Tab Preview Names #2891

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

AJAYINAVOLU
Copy link
Contributor

Description

This PR fixes the Project WBS List caused by the .container (src\components\Collaboration\Collaboration.css). After merging collaboration.css, the global .container class applied align-items: center, causing layout compression in the project WBS list view. Added style={{ alignItems: 'normal' }} to the <div className="container pt-2"> to override the conflicting CSS and restore proper alignment.
Replaced titles containing fullName with generic names (User Profile, Edit User Profile) to avoid displaying "Default User" in cases where authUser fails to load. This ensures a consistent user experience regardless of authentication state.

Related PRS (if any):

This frontend PR is related to the development branch of the backend repository.

Main changes explained:

  • Update src/components/App.jsx to use generic titles for user profile pages.
  • Update src/components/Projects/WBS/wbs.jsx for fixing the alignment issues.

How to test:

  1. Check into the current frontend branch and the development backend branch.
  2. Do npm install and npm run start:local to run this PR locally.
  3. Clear site data/cache.
  4. Log in as an owner-user.
  5. Go to Dashboard→ Other Links→ Projects→ WBS Icon of any project→ WBS List Page.
  6. Verify the Back button and the "Return to Project List" is rendered properly and when clicked return to the project list.
  7. Verify the "Project Name: " title is rendered properly.
  8. Next, Go to Dashboard→ Welcome, UserName→ View Profile.
  9. Check that the browser tab displays a relevant preview name based on the current page content.

Screenshots or videos of changes:

image image

Copy link

netlify bot commented Nov 23, 2024

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit d36a369
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/674229d8341316000800115e
😎 Deploy Preview https://deploy-preview-2891--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@nikhilpittala16 nikhilpittala16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the PR and everything works as expected.

PR.vid.101.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants