Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying the [spacebar] section doesn’t generate the right .keylayout #81

Open
robinmoussu opened this issue Jan 31, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@robinmoussu
Copy link
Contributor

I took ergol.toml, modified the name8 to "modified-spacebar", and the [spacebar] section to have easy to search symbols names.

  [spacebar]
  shift       = "\u9991"
  altgr       = "\u9992"
  altgr_shift = "\u9993"
  1dk         = "\u9994"
  1dk_shift   = "\u9995"

In the output of kalamine build double_identifier.toml:

  • dist/modify-spacebar.xkb correctly contains the following output:
     // Space bar
    key <SPCE> {[ space           , U9991           , U9994           , U9994           ],[ U9992           , U9993           ]}; //   馑 馔 馔 馒 馓
  • however dist/modify-spacebar.keylayout doesn’t have any modification passed on.

I assume the code just take default hardcoded values instead of the user-specified one. I am not sure which symbols would have been the best to to this test. Apparently 999x is in the Chinese plane! I am not sure if after the fix kalamine will display the hex value of the kenji. The part of the output that must be modified are the one after each <!-- Space bar -->, and the last 3 actions blocks.

(btw it’s not possible to remap the spacebar, we don’t have a alpha = "…" entry in the [spacebar] section, but who would want that !)

modify-spacebar.toml.txt
modify-spacebar.keylayout.txt
modify-spacebar.keylayout.expected.txt

@fabi1cazenave fabi1cazenave added the bug Something isn't working label Jan 31, 2024
@fabi1cazenave
Copy link
Collaborator

(btw it’s not possible to remap the spacebar, we don’t have a alpha = "…" entry in the [spacebar] section, but who would want that !)

There are languages where the space character is not used, e.g. Chinese and Japanese IIRC. So it might be interesting to support it for the sake of completeness, but that would be really low in the priority list. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants