From 29eb52f78c30bd30436f616a08fd207b20109e65 Mon Sep 17 00:00:00 2001
From: Phillipp Glanz <6745190+TheMeinerLP@users.noreply.github.com>
Date: Sun, 26 May 2024 20:15:49 +0200
Subject: [PATCH] [#34] Add deprecation text to old notification system

---
 .../java/net/minestom/server/advancements/AdvancementTab.java | 4 +---
 .../server/advancements/notifications/Notification.java       | 3 +++
 .../server/advancements/notifications/NotificationCenter.java | 3 +++
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/src/main/java/net/minestom/server/advancements/AdvancementTab.java b/src/main/java/net/minestom/server/advancements/AdvancementTab.java
index 8228a5ddd1e..0f39baf1431 100644
--- a/src/main/java/net/minestom/server/advancements/AdvancementTab.java
+++ b/src/main/java/net/minestom/server/advancements/AdvancementTab.java
@@ -155,10 +155,8 @@ private void addPlayer(@NotNull Player player) {
      */
     private void removePlayer(@NotNull Player player) {
         final UUID uuid = player.getUuid();
-        if (!PLAYER_TAB_MAP.containsKey(uuid)) {
-            return;
-        }
         Set<AdvancementTab> tabs = PLAYER_TAB_MAP.get(uuid);
+        if (tabs == null) return;
         tabs.remove(this);
         if (tabs.isEmpty()) {
             PLAYER_TAB_MAP.remove(uuid);
diff --git a/src/main/java/net/minestom/server/advancements/notifications/Notification.java b/src/main/java/net/minestom/server/advancements/notifications/Notification.java
index 4d543a0aae9..29854f9ada3 100644
--- a/src/main/java/net/minestom/server/advancements/notifications/Notification.java
+++ b/src/main/java/net/minestom/server/advancements/notifications/Notification.java
@@ -8,7 +8,10 @@
 
 /**
  * Represents a message which can be sent using the {@link NotificationCenter}.
+ * @deprecated As of Minestom 22a8ccabfae38c53df0605000aa7eed49765c1ab, because the Maintainability is very hard and
+ *      can break everytime from Mojang side because bad api design use {@link net.minestom.server.notifications.Notification#builder()} instead.
  */
+@Deprecated(since = "1.4.1", forRemoval = true)
 public record Notification(@NotNull Component title, @NotNull FrameType frameType, @NotNull ItemStack icon) {
     public Notification(@NotNull Component title, @NotNull FrameType frameType, @NotNull Material icon) {
         this(title, frameType, ItemStack.of(icon));
diff --git a/src/main/java/net/minestom/server/advancements/notifications/NotificationCenter.java b/src/main/java/net/minestom/server/advancements/notifications/NotificationCenter.java
index 5c5326b3c35..405a131dc85 100644
--- a/src/main/java/net/minestom/server/advancements/notifications/NotificationCenter.java
+++ b/src/main/java/net/minestom/server/advancements/notifications/NotificationCenter.java
@@ -14,7 +14,10 @@
  * Works by sending a completed advancement and remove it immediately.
  * <p>
  * You can simply create a {@link Notification} object and call {@link #send(Notification, Player)}.
+ * @deprecated As of Minestom 22a8ccabfae38c53df0605000aa7eed49765c1ab, because the Maintainability is very hard and
+ *      can break everytime from Mojang side because bad api design use {@link net.minestom.server.notifications.Notification#builder()} instead.
  */
+@Deprecated(since = "1.4.1", forRemoval = true)
 public final class NotificationCenter {
     private static final String IDENTIFIER = "minestom:notification";
     private static final AdvancementsPacket REMOVE_PACKET = new AdvancementsPacket(false, List.of(), List.of(IDENTIFIER), List.of());