Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0.2] iOS: Argument 2 (RCTResponseSenderBlock) of setExternalUserId must not be null #1139

Closed
diego-paired opened this issue Jan 9, 2021 · 3 comments

Comments

@diego-paired
Copy link

diego-paired commented Jan 9, 2021

Description:
Since upgrading to 4.0.2 from 4.0.1, the following error appears when calling setExternalUserId:
image

This error did not happen on 4.0.1, and the typescript definitions mark the second argument as optional.

Environment

react: 17.0.1 => 17.0.1 
react-native: ^0.64.0-rc.2 => 0.64.0-rc.2 

"react-native-onesignal": "^4.0.2"

@rgomezp
Copy link
Contributor

rgomezp commented Jan 10, 2021

Howdy Diego,
Thank you for reporting this issue. Can you please provide more information regarding the exact environment?

Also, what does your call look like? Can you please include a code snippet?

From looking at the code, it looks like your issue might be able to be resolved by passing an empty callback for now as a temporary workaround:

()=>{}

We will look to implement a long term fix for this in the future.

Cheers

@alimek
Copy link

alimek commented Jan 11, 2021

Faced the same issue when fast-refresh happened, but not every time 🤔 passing empty handler fixing issue for now

@rgomezp
Copy link
Contributor

rgomezp commented Jan 11, 2021

Howdy,
This should now be resolved in 4.0.3

Enjoy!

@rgomezp rgomezp closed this as completed Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants