Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic backoff/retry on HTTP 429 Too Many Requests #441

Open
soxofaan opened this issue Jun 15, 2023 · 2 comments · May be fixed by #547
Open

Automatic backoff/retry on HTTP 429 Too Many Requests #441

soxofaan opened this issue Jun 15, 2023 · 2 comments · May be fixed by #547
Assignees
@soxofaan
Labels
feature request

Comments

@soxofaan
Copy link
Member

Some backends have middleware to throttle the number of concurrent requests, returning a 429 Too Many Requests if some limit is exceeded. The python client could provide automatic retry with (e.g. exponential) backoff functionality.

related to #440
@jdries
Copy link
Collaborator

jdries commented Jun 30, 2023

The python requests library even supports this quite easily

from requests.adapters import HTTPAdapter, Retry
retries = Retry(total=5,read=10,other=10,status=10,
                backoff_factor=0.1,
                status_forcelist=[ 502, 503, 504,404,429],
                method_whitelist=["HEAD", "GET", "OPTIONS","POST"])
session.mount('https://', HTTPAdapter(max_retries=retries))
session.mount('http://', HTTPAdapter(max_retries=retries))

@soxofaan
Copy link
Member Author

indeed, we might consider moving this helper from python driver to python client: https://github.com/Open-EO/openeo-python-driver/blob/b9f465dc276a3d0b0217d7f76a416b7cb943cd38/openeo_driver/util/http.py#L7-L31

and we apparently also have it in MultiBackendJobManager:

openeo-python-client/openeo/extra/job_management.py

Lines 148 to 167 in 95b89d5

def _make_resilient(self, connection):
"""Add an HTTPAdapter that retries the request if it fails.
Retry for the following HTTP 50x statuses:
502 Bad Gateway
503 Service Unavailable
504 Gateway Timeout
"""
status_forcelist = [502, 503, 504]
retries = Retry(
total=MAX_RETRIES,
read=MAX_RETRIES,
other=MAX_RETRIES,
status=MAX_RETRIES,
backoff_factor=0.1,
status_forcelist=status_forcelist,
allowed_methods=["HEAD", "GET", "OPTIONS", "POST"],
)
connection.session.mount("https://", HTTPAdapter(max_retries=retries))
connection.session.mount("http://", HTTPAdapter(max_retries=retries))

JohanKJSchreurs added a commit that referenced this issue Oct 24, 2023
@JohanKJSchreurs
Issue #441 Add retry function borrowed from openeo-python-driver
d68747c
JohanKJSchreurs added a commit that referenced this issue Oct 24, 2023
@JohanKJSchreurs
Issue #441 Add automatic retry to RestApiConnection's request session
86f4c72
@jdries jdries linked a pull request Mar 12, 2024 that will close this issue
Issue441 automatic backoff retry on http429 #547
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soxofaan soxofaan

Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue441 automatic backoff retry on http429 Open-EO/openeo-python-client
3 participants
@soxofaan @jdries @JohanKJSchreurs