Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #437 Better documentation of CRS code usage, and slightly more … #462

Closed

Conversation

JohanKJSchreurs
Copy link
Contributor

Issue #437 Better documentation of CRS code usage, and slightly more test coverage

Implements: #437

@JohanKJSchreurs JohanKJSchreurs marked this pull request as draft August 17, 2023 19:59
Copy link
Member

@soxofaan soxofaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some initial notes

openeo/rest/datacube.py Outdated Show resolved Hide resolved
openeo/rest/datacube.py Outdated Show resolved Hide resolved
openeo/rest/datacube.py Outdated Show resolved Hide resolved
openeo/rest/datacube.py Outdated Show resolved Hide resolved
openeo/util.py Outdated Show resolved Hide resolved
openeo/rest/datacube.py Outdated Show resolved Hide resolved
@JohanKJSchreurs JohanKJSchreurs marked this pull request as ready for review September 5, 2023 10:10
soxofaan added a commit that referenced this pull request Sep 11, 2023
reported initially from PR #462
@JohanKJSchreurs JohanKJSchreurs force-pushed the issue437_better-documentation-of-crs-code-usage branch from 85252b8 to 401bbfc Compare September 12, 2023 11:56
soxofaan added a commit that referenced this pull request Sep 12, 2023
@soxofaan
Copy link
Member

did some final finetuning, rebased and merged in 4efb921

thanks!

@soxofaan soxofaan closed this Sep 12, 2023
@soxofaan soxofaan linked an issue Sep 12, 2023 that may be closed by this pull request
@soxofaan soxofaan deleted the issue437_better-documentation-of-crs-code-usage branch September 12, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better documentation and validation/normalization of CRS code usage
2 participants