Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check also existing data on loading an operation #2484

Open
ReimarBauer opened this issue Aug 24, 2024 · 1 comment
Open

check also existing data on loading an operation #2484

ReimarBauer opened this issue Aug 24, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@ReimarBauer
Copy link
Member

ReimarBauer commented Aug 24, 2024

A wrong dataset gives in 9.2.0 and needs maybe a similar fix as for #2456

Fatal error in MSS 9.2.0 on Linux-6.5.0-10043-tuxedo-x86_64-with-glibc2.35
Python 3.11.9 | packaged by conda-forge | (main, Apr 19 2024, 18:36:13) [GCC 12.3.0]

Please report bugs in MSS to https://github.com/Open-MSS/MSS

Information about the fatal error:

Traceback (most recent call last):
  File "/home/reimar/Miniforge/envs/mssenv9.2.0/lib/python3.11/site-packages/mslib/msui/mscolab.py", line 1772, in set_active_op_id
    self.load_wps_from_server()
  File "/home/reimar/Miniforge/envs/mssenv9.2.0/lib/python3.11/site-packages/mslib/msui/mscolab.py", line 1911, in load_wps_from_server
    self.waypoints_model = ft.WaypointsTableModel(xml_content=xml_content)
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/reimar/Miniforge/envs/mssenv9.2.0/lib/python3.11/site-packages/mslib/msui/flighttrack.py", line 202, in __init__
    self.load_from_xml_data(xml_content)
  File "/home/reimar/Miniforge/envs/mssenv9.2.0/lib/python3.11/site-packages/mslib/msui/flighttrack.py", line 657, in load_from_xml_data
    raise SyntaxError(f"Invalid flight track filename: {name}")
SyntaxError: Invalid flight track filename: Flight track
@ReimarBauer ReimarBauer added the bug Something isn't working label Aug 24, 2024
@ReimarBauer ReimarBauer self-assigned this Aug 24, 2024
@ReimarBauer
Copy link
Member Author

ReimarBauer commented Aug 24, 2024

We maybe better should filter them on the server and not add them to the operation list. e.g. collect in some different list, disable them, define an invalid attribute in the dbase, write a log entry. So that only 1 request is needed.

Would we do only a similiar fix as mentioned above they are still in the operation list. In the UI there of course we can use the same check and use a popup message when a user activates such an incomplete dataset but we have then to undo the activation too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant