From 0d75fa7d349f3f57a67df6d25e42958fae3a7afd Mon Sep 17 00:00:00 2001 From: Tammy Leino Date: Thu, 14 Apr 2022 13:00:45 -0700 Subject: [PATCH] remoteproc_get_mem could wrongly match on name Bound name comparison by RPROC_MAX_NAME_LEN instead of length of search string Signed-off-by: Tammy Leino --- lib/remoteproc/remoteproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/remoteproc/remoteproc.c b/lib/remoteproc/remoteproc.c index ba458bbe9..8ae4bb8eb 100644 --- a/lib/remoteproc/remoteproc.c +++ b/lib/remoteproc/remoteproc.c @@ -48,7 +48,7 @@ remoteproc_get_mem(struct remoteproc *rproc, const char *name, metal_list_for_each(&rproc->mems, node) { mem = metal_container_of(node, struct remoteproc_mem, node); if (name) { - if (!strncmp(name, mem->name, strlen(name))) + if (!strncmp(name, mem->name, RPROC_MAX_NAME_LEN)) return mem; } else if (pa != METAL_BAD_PHYS) { metal_phys_addr_t pa_start, pa_end;