Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C][Client] Support free-form objects #12557

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

ityuhui
Copy link
Contributor

@ityuhui ityuhui commented Jun 8, 2022

@wing328 @zhemant @michelealbano

The PR #12069 adds the support for free-form objects. That is a very useful feature.
I'd like to submit the code on behalf of the author @harlequin-tech. So I picked up the two files and updated them according to my thoughts.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.0.1) (patch release), 6.1.x (breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Jun 13, 2022

Built without issues locally:

/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[  6%] Building C object CMakeFiles/openapi_petstore.dir/src/list.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 13%] Building C object CMakeFiles/openapi_petstore.dir/src/apiKey.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 20%] Building C object CMakeFiles/openapi_petstore.dir/src/apiClient.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 26%] Building C object CMakeFiles/openapi_petstore.dir/external/cJSON.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 33%] Building C object CMakeFiles/openapi_petstore.dir/model/object.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 40%] Building C object CMakeFiles/openapi_petstore.dir/model/api_response.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 46%] Building C object CMakeFiles/openapi_petstore.dir/model/category.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 53%] Building C object CMakeFiles/openapi_petstore.dir/model/order.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 60%] Building C object CMakeFiles/openapi_petstore.dir/model/pet.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 66%] Building C object CMakeFiles/openapi_petstore.dir/model/tag.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 73%] Building C object CMakeFiles/openapi_petstore.dir/model/user.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 80%] Building C object CMakeFiles/openapi_petstore.dir/api/PetAPI.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 86%] Building C object CMakeFiles/openapi_petstore.dir/api/StoreAPI.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 93%] Building C object CMakeFiles/openapi_petstore.dir/api/UserAPI.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[100%] Linking C shared library libopenapi_petstore.so
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[100%] Built target openapi_petstore
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[  6%] Building C object CMakeFiles/openapi_petstore.dir/src/list.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 13%] Building C object CMakeFiles/openapi_petstore.dir/src/apiKey.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 20%] Building C object CMakeFiles/openapi_petstore.dir/src/apiClient.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 26%] Building C object CMakeFiles/openapi_petstore.dir/external/cJSON.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 33%] Building C object CMakeFiles/openapi_petstore.dir/model/object.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 40%] Building C object CMakeFiles/openapi_petstore.dir/model/api_response.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 46%] Building C object CMakeFiles/openapi_petstore.dir/model/category.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 53%] Building C object CMakeFiles/openapi_petstore.dir/model/order.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 60%] Building C object CMakeFiles/openapi_petstore.dir/model/pet.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 66%] Building C object CMakeFiles/openapi_petstore.dir/model/tag.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 73%] Building C object CMakeFiles/openapi_petstore.dir/model/user.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 80%] Building C object CMakeFiles/openapi_petstore.dir/api/PetAPI.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 86%] Building C object CMakeFiles/openapi_petstore.dir/api/StoreAPI.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 93%] Building C object CMakeFiles/openapi_petstore.dir/api/UserAPI.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[100%] Linking C shared library libopenapi_petstore.so
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[100%] Built target openapi_petstore
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)

@wing328 wing328 merged commit bf22f38 into OpenAPITools:master Jun 13, 2022
@wing328 wing328 added this to the 6.0.1 milestone Jun 13, 2022
@ityuhui ityuhui deleted the yh-freeform-object-0608 branch June 13, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants