Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes double serialization bug in python-experimental #12561

Merged
merged 23 commits into from
Jun 13, 2022

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Jun 8, 2022

Parameter serialization is complicated
This PR updates the parameter serialization code to work more simply and fixes a bug where query/path params were being double url encoded

Now path and query parameters are serialized separately and stored in the url string. That url is then passed into the rest client.

  • Tests added confirming that path and query parameters are percent encoded serialized

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.0.1) (patch release), 6.1.x (breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@spacether spacether marked this pull request as draft June 8, 2022 23:04
@spacether spacether linked an issue Jun 8, 2022 that may be closed by this pull request
6 tasks
@spacether spacether changed the title Fixes double serialization bug in python-experimental [WIP ] Fixes double serialization bug in python-experimental Jun 8, 2022
@spacether spacether changed the title [WIP ] Fixes double serialization bug in python-experimental [WIP] Fixes double serialization bug in python-experimental Jun 8, 2022
@spacether spacether changed the title [WIP] Fixes double serialization bug in python-experimental Fixes double serialization bug in python-experimental Jun 13, 2022
@spacether spacether marked this pull request as ready for review June 13, 2022 04:21
@spacether spacether added this to the 6.0.1 milestone Jun 13, 2022
@spacether spacether merged commit a00ae46 into master Jun 13, 2022
@spacether spacether deleted the feat_python_exp_stop_double_serialization branch June 13, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][python-experimental] double URL encoding of path parameters?
1 participant