Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csharp-netcore] fix: url escaping #12739

Merged
merged 3 commits into from
Jun 30, 2022

Conversation

Anakael
Copy link
Contributor

@Anakael Anakael commented Jun 29, 2022

HttpUtility.UrlEncode converts space to + instead of %20 which is leads to error in parsing on server side.
Uri.EscapeDataString is right methods for escaping.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.0.1) (patch release), 6.1.x (breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@Anakael
Copy link
Contributor Author

Anakael commented Jun 29, 2022

@mandrean @frankyjuang @shibayan @Blackclaws @lucamazzanti

@wing328
Copy link
Member

wing328 commented Jun 30, 2022

LGTM. Thanks for the fix.

@wing328 wing328 merged commit 280de38 into OpenAPITools:master Jun 30, 2022
@wing328 wing328 added this to the 6.0.1 milestone Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants