[php-symfony] Support for default scalar value of properties in model #16605
Conversation
…els. Default values now returns in getter-functions
| { | ||
| return $this->{{name}}; | ||
| return {{#defaultValue}}$this->{{name}} ?? {{{defaultValue}}}{{/defaultValue}}{{^defaultValue}}$this->{{name}}{{/defaultValue}}; |
There was a problem hiding this comment.
@reznikartem thanks for the PR. Should the default value be assigned in the constructor instead?
If we do this in the getter, that means we can't set a property to null (assuming the property is nullable)
There was a problem hiding this comment.
Hi, @wing328
Thank you for answer. You are right, i`ve missed this moment. Revert type-hinting in second commit to initial state. And move default value of properties into property initializator.
__constructor bad place for default values because of it`s not running when object created by jms serializer, from json string.
In constructor i`m added checks with array_key_exist. Now default values will be present in objects, and they can be replaced with null for nullable properties, if this null value presents in $data array. If key not present in $data array, then default value will be available from getter.
…erty initialize. Made changes in __construct: Now value of properties rewrites only if key exist in $data array.
…OpenAPITools#16605) * Add support for default scalar value of properties in php-symfony models. Default values now returns in getter-functions * Revert nullable type-hinting. Move default values from getter to property initialize. Made changes in __construct: Now value of properties rewrites only if key exist in $data array.
After PR #12532 in php-symfony model does not exist default values from OpenApi specification. This commit add support for default scalar value of properties in php-symfony model. Default values now returns in getter-functions, and return type in getter function changed to not nullable/
@jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12)