Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elixir] Adds workaround for httpc for post/put/patch requests #5682

Merged
merged 3 commits into from
Jan 26, 2021

Conversation

mrmstn
Copy link
Contributor

@mrmstn mrmstn commented Mar 23, 2020

This PR will fix #5403 by adding an empty string if no body was defined for requests with a method of POST, PATCH or PUT.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
    cc: @wing328

@mrmstn mrmstn changed the title Adds workaround for httpc for post/put/patch requests WIP: Adds workaround for httpc for post/put/patch requests Mar 23, 2020
@mrmstn
Copy link
Contributor Author

mrmstn commented Mar 23, 2020

Thins I need to check before merging:
What about

  • file uploads
  • optional body params

@richardwhiuk richardwhiuk changed the title WIP: Adds workaround for httpc for post/put/patch requests WIP: [Elixir] Adds workaround for httpc for post/put/patch requests Mar 24, 2020
@mrmstn mrmstn closed this Oct 5, 2020
@mrmstn mrmstn reopened this Oct 5, 2020
@mrmstn mrmstn changed the title WIP: [Elixir] Adds workaround for httpc for post/put/patch requests [Elixir] Adds workaround for httpc for post/put/patch requests Oct 5, 2020
@mrmstn
Copy link
Contributor Author

mrmstn commented Oct 5, 2020

I've changed the way to handle this.. now, the generator looks for a required body params (forms included). If one is found, the patch doesn't need to take place.

The patch itself will simply look if a body param was set by one of the optional body params. If the body is still not present or nil, it it will be replaces by an empty string.

@wing328 Could you do me the honor and give me a short review on this PR? :)

@wing328 wing328 added this to the 5.0.1 milestone Jan 25, 2021
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Local tests passed as well.

@wing328 wing328 merged commit 0ae5491 into OpenAPITools:master Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Elixir] Missing body in POST or PUT cause crash (Simple Fix!)
3 participants