[dart-dio] Allow dynamic headers and add additional dio parameters #8191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 15, 2020
agilob
reviewed
Dec 15, 2020
| ProgressCallback onSendProgress, | ||
| ProgressCallback onReceiveProgress, | ||
| }) async { | ||
| final String _path = '{{{path}}}'{{#pathParams}}.replaceAll('{' r'{{baseName}}' '}', {{{paramName}}}.toString()){{/pathParams}}; | ||
|
|
||
| final Map<String, dynamic> queryParams = {}; | ||
| final Map<String, String> headerParams = Map.from(headers ?? {}); | ||
| final Map<String, dynamic> headerParams = { | ||
| if (headers != null) ...headers, |
There was a problem hiding this comment.
never seen this syntax before. basically headerParams gets content of headers if headers is initialised?
There was a problem hiding this comment.
Ya basically like the ecma spread operator. Works for all collections.
agilob
approved these changes
Dec 15, 2020
josh-burton
approved these changes
Dec 15, 2020
|
@kuhnroyal I just rebased and merged #6915. Can you please rebase this one to resolve the merge conflicts when you've time? |
|
@wing328 On it. |
* fixes some compile errors due to header params not being of type `String` * add optional `extra` and `validateStatus` parameters from dio
kuhnroyal
force-pushed
the
dart-dio/api-parameters
branch
from
8c89d88
to
0eb3717
Compare
|
@wing328 rebased |
|
CircleCI failure not related to this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringextraandvalidateStatusparameters from dio to API callsContains the same changes as #6915 and fixes compile issues for dart-dio mentioned in #8179.
Regarding the concerns in #6915 about missing changes to the dart generator:
http.Clientonly handlesStringheaders where asdiocan handledynamicheaders and does its own serialization of headersPR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.masterCC @swipesight (2018/09) @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12)