Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C][Client] Disable escaping the parameter name in URL path string #8243

Merged

Conversation

ityuhui
Copy link
Contributor

@ityuhui ityuhui commented Dec 20, 2020

When the path parameter name is a C/C++ keyword, e.g. namespace, the generated code will escape the parameter name, e.g. _namespace:

    snprintf(localVarPath, sizeOfPath, "/apis/apps/v1/namespaces/{namespace}/controllerrevisions");

    // Path Params
    long sizeOfPathParams__namespace = strlen(_namespace)+3 + strlen("{ _namespace }");
...
    char* localVarToReplace__namespace = malloc(sizeOfPathParams__namespace);
    sprintf(localVarToReplace__namespace, "{%s}", "_namespace");   //<--- This is not right, {_namespace} cannot replace namespace in localVarPath "/apis/apps/v1/namespaces/{namespace}/controllerrevisions"

    localVarPath = strReplace(localVarPath, localVarToReplace__namespace, _namespace);

The {_namespace} in localVarToReplace__namespace should not be escaped, it should be {namespace}, then it can be used to replace in localVarPath "/apis/apps/v1/namespaces/{namespace}/controllerrevisions"

So this PR will disable escaping the parameter name in URL path string.

This PR relays the PR #8205

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 @zhemant @michelealbano

@auto-labeler
Copy link

auto-labeler bot commented Dec 20, 2020

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@wing328 wing328 added this to the 5.0.1 milestone Jan 4, 2021
@wing328
Copy link
Member

wing328 commented Jan 4, 2021

@ityuhui thanks for the fix. CI failure not related to this PR.

@wing328 wing328 merged commit a812bf1 into OpenAPITools:master Jan 4, 2021
@ityuhui ityuhui deleted the yh-disable-path-parameter-escape branch January 5, 2021 02:05
@ityuhui
Copy link
Contributor Author

ityuhui commented Jan 5, 2021

Thanks @wing328

And because this PR has been merged, another PR #8205 can be merged too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants