[dart][dart-dio] Generate the correct serializers #8357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* only generate actually used serializers (anything used in body or response) * generate previously missing serializers for collection types * improve formatting
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
josh-burton
approved these changes
Jan 6, 2021
agilob
reviewed
Jan 6, 2021
| @@ -289,6 +289,7 @@ public void postProcessModelProperty(CodegenModel model, CodegenProperty propert | |||
| Map<String, Object> operations = (Map<String, Object>) objs.get("operations"); | |||
| List<CodegenOperation> operationList = (List<CodegenOperation>) operations.get("operation"); | |||
|
|
|||
| Set<Map<String, Object>> serializers = new HashSet<>(); | |||
There was a problem hiding this comment.
are you sure this needs to be a set of maps? why not something simpler to debug like a list of tuples?
There was a problem hiding this comment.
I am not sure what mustache supports here, I assume with pairs you would somehow have to access .first .second in the templates, never seen this. I just followed the same way that is used everywhere else.
agilob
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8270
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master,5.1.x,6.0.xCC @swipesight (2018/09) @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12)