[PYTHON] use customized default Configuration() objects if available #8500
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be reviewed by the Python Technical Committee:
@taxpon @frol @mbohlool @cbornet @kenjones-cisco @tomplus @Jyhess @arun-nalla @spacether
For the Python variants, the generated
PACKAGENAME.configuration.Configuration
class allows the programmer to save the data from pre-configured instance of it as the default to be used for future instances.However, this requires the classes to be instantiated using
Configuration.get_default_copy()
, rather than justConfiguration()
.This PR changes the templates/samples to use the
Configuration.get_default_copy()
wherever a nakedConfiguration()
was found.This has the effect of making the programmer's stored Configuration be used (such as to override the client-side verification setting), if the programmer set one, and the hard-coded defaults used otherwise.
Related Issue: #8499
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x