Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent serialisation of English/Welsh names #12

Open
giacecco opened this issue Feb 26, 2015 · 0 comments
Open

Inconsistent serialisation of English/Welsh names #12

giacecco opened this issue Feb 26, 2015 · 0 comments
Labels

Comments

@giacecco
Copy link
Contributor

Minor. When an address has no locality, the JSON contains "locality":{"name":{"en":[null],"cy":[]},"url":null} rather than "locality":{"name":{"en":[],"cy":[]},"url":null}.

Someone may argue that locality should not be defined at all in cases like that, but I believe @pezholio at the time suggested that it is best practice to do like this, despite the issue of making the JSON even bigger than it is already. I can live with that :-)

... but the inconsistency between [ null ] and [ ] could be tricky to developers.

@giacecco giacecco added the bug label Feb 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant