Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provenance data inconsistent with Turbot #28

Open
JeniT opened this issue Feb 23, 2015 · 6 comments
Open

Provenance data inconsistent with Turbot #28

JeniT opened this issue Feb 23, 2015 · 6 comments

Comments

@JeniT
Copy link

JeniT commented Feb 23, 2015

The documentation in the README says to use processingScript. The documentation on the website says to use processing_scripts and processing_script. Which is correct or are they all acceptable?

@JeniT
Copy link
Author

JeniT commented Feb 23, 2015

and the Turbot documentation says something similar to the Ernest website so there's inconsistency there too, hence the title of the issue as that's where I spotted it first

@Floppy
Copy link
Contributor

Floppy commented Feb 23, 2015

My mistake, it should be processing_script. See https://github.com/OpenAddressesUK/ernest/blob/master/lib/jobs/create_address.rb#L45

@Floppy
Copy link
Contributor

Floppy commented Feb 23, 2015

I think I got all javascripty. I should change userInput to user_input for consistency as well.

@JeniT
Copy link
Author

JeniT commented Feb 23, 2015

I fixed the README, but there's still inconsistency. See the search for processing_scripts. Or do these mean different things?

@Floppy
Copy link
Contributor

Floppy commented Feb 23, 2015

mmm, I'll have to check this when I can concentrate properly. /cc @pezholio

@pezholio
Copy link
Member

Ah, I think processing_scripts here refers to a repo, whereas processing_script refers to a particular file and ref

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants