Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The start_master_and_slave.sh which run by github CI need to be revised #2614

Closed
cheniujh opened this issue Apr 18, 2024 · 0 comments · Fixed by #2615
Closed

The start_master_and_slave.sh which run by github CI need to be revised #2614

cheniujh opened this issue Apr 18, 2024 · 0 comments · Fixed by #2615

Comments

@cheniujh
Copy link
Collaborator

cheniujh commented Apr 18, 2024

Is this a regression?

No

Description

image
1 the binary result from CI compile(which is used for CI testing later on) is right in the ${{ github.workspace }}/build/pika. Should not and no need to copy from "../../output/pika"
2 in ubuntu and centos of CI, when exec start_master_and_slave.sh, sed will throw "sed: can't read : No such file or directory" although it actually worked. this is due to the script uses the Mac exclusive format {sed -i '' ...} while in ubuntu/centos this should be {sed -i} , without the ''

1 CI 编译出的二进制结果(稍后用于 CI 测试)就在 ${{ github.workspace }}/build/ 中,不应该也不需要从 "../../output/pika" 复制,这个cp命令实际上是失败的,只是正好用于测试的二进制就处于当前目录下,所以后续的CI能顺利运行
2 sed命令在ubuntu和centos中会报错(但实际上还是生效了,完成了参数替换),因为使用的是sed -i '',这种mac写法,在ubuntu/centos上应该使用 sed -i (不带'')

Please provide a link to a minimal reproduction of the bug

No response

Screenshots or videos

No response

Please provide the version you discovered this bug in (check about page for version information)

No response

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants