Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade CKeditor to latest version #1765

Closed
guillaumejparis opened this issue Oct 29, 2024 · 1 comment · Fixed by #1766
Closed

Upgrade CKeditor to latest version #1765

guillaumejparis opened this issue Oct 29, 2024 · 1 comment · Fixed by #1766
Assignees
@guillaumejparis
Labels
feature use for describing a new feature to develop solved The issue has been solved technical improvement Technical refactor or improvement is needed
Milestone
Release 1.9.0

Comments

@guillaumejparis
Copy link
Member

Change the way we use CKEditor in OpenBAS.

Actual usage:
We have fetched a fix version of CKEditor and build a lib ourselves with the config we want to use it in our code.

New usage:
We fetch CKEditor from yarn as any other libs of the project and use it directly inside a new React component CKEditor that initiate the config to keep same behavior we had with the older build.

The advantage of this is that it's easier to keep an up-to-date version of CKEditor.
@guillaumejparis guillaumejparis added feature use for describing a new feature to develop technical improvement Technical refactor or improvement is needed labels Oct 29, 2024
@guillaumejparis guillaumejparis self-assigned this Oct 29, 2024
@guillaumejparis
Copy link
Member Author

OpenCTI issue & PR :
OpenCTI-Platform/opencti#8577
OpenCTI-Platform/opencti#8151

@guillaumejparis guillaumejparis added this to the Release 1.9.0 milestone Oct 29, 2024
@guillaumejparis guillaumejparis mentioned this issue Oct 29, 2024
Merged
guillaumejparis added a commit that referenced this issue Oct 29, 2024
@guillaumejparis
[frontend] Migrate CK Editor to 9.3 (#1765)
1696e00
guillaumejparis added a commit that referenced this issue Oct 29, 2024
@guillaumejparis
[frontend] Migrate CK Editor to 9.3 (#1765)
b413b24
@RomuDeuxfois RomuDeuxfois added the solved The issue has been solved label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guillaumejparis guillaumejparis

Labels
feature use for describing a new feature to develop solved The issue has been solved technical improvement Technical refactor or improvement is needed
Projects
None yet
Milestone
Release 1.9.0
Development

Successfully merging a pull request may close this issue.

[frontend] Migrate CK Editor to 9.3 OpenBAS-Platform/openbas
3 participants
@SamuelHassine @guillaumejparis @RomuDeuxfois