Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with overall_score computation #8

Open
dvsrepo opened this issue Nov 15, 2023 · 6 comments
Open

Issue with overall_score computation #8

dvsrepo opened this issue Nov 15, 2023 · 6 comments

Comments

@dvsrepo
Copy link

dvsrepo commented Nov 15, 2023

Hi!

Congrats on this amazing project.

We've been exploring the data and identified an issue with very high overall_score responses. The issue seems to be related with this line. This causes responses with a critique rating of 1 to become a 10. We noticed this by looking at the critique rational which was highly negative for many (~2K) examples with an overall_score of 10.

@lifan-yuan
Copy link
Collaborator

Hi!

Sorry for the late response and thanks for pointing that out! Yes, it seems to be a bug, and the ">" should be ">=".

Intuitively, a true 10 score should correspond to high fine-grained scores while a mistaken 10 relates to low ones. We will check all the 2k samples immediately.

@dvsrepo
Copy link
Author

dvsrepo commented Dec 1, 2023

Here's a space we've been using to verify this:

https://argilla-ultrafeedback-curator.hf.space/dataset/39de1a2e-d905-46bd-b940-42e06b6e0c06/annotation-mode?_page=1&_status=discarded

(login with: owner/12345678)

The only issue is that there's some examples with overall_score 10 that are good (the majority are bad though).

We've been working on curating this data programmatically and with Argilla and we'd be super happy to contribute back

Thanks for building an amazing project!

@ehartford
Copy link

Can't wait to see the updated dataset!

@lifan-yuan
Copy link
Collaborator

Just updated the dataset, please check!

@ehartford
Copy link

@lifan-yuan
Copy link
Collaborator

Oh no, on our official page: https://huggingface.co/datasets/openbmb/UltraFeedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants