Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] getFrame space check incorrecty uses self #280

Closed
lohedges opened this issue Apr 29, 2024 · 0 comments · Fixed by #281
Closed

[BUG] getFrame space check incorrecty uses self #280

lohedges opened this issue Apr 29, 2024 · 0 comments · Fixed by #281
Assignees
@lohedges
Labels
bug Something isn't working exscientia Related to work with Exscientia

Comments

@lohedges
Copy link
Contributor

As in the title, the check for a space property in this function incorrectly uses self, presumably because the logic was copied from the Trajectory class.
@lohedges lohedges added bug Something isn't working exscientia Related to work with Exscientia labels Apr 29, 2024
@lohedges lohedges self-assigned this Apr 29, 2024
lohedges added a commit that referenced this issue Apr 29, 2024
@lohedges
Remove self from property_map since this is a function. [closes #280]
6f5dd2d
@lohedges lohedges mentioned this issue Apr 29, 2024
Merged
xiki-tempula pushed a commit to Exscientia/biosimspace that referenced this issue May 7, 2024
@lohedges @xiki-tempula
Remove self from property_map since this is a function. [closes OpenB…
7dd8057 
…ioSim#280]
lohedges added a commit that referenced this issue May 7, 2024
@lohedges
Merge pull request #281 from OpenBioSim/fix_280
6d431c5 
Fix issue #280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lohedges lohedges

Labels
bug Something isn't working exscientia Related to work with Exscientia
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue #280 OpenBioSim/biosimspace
1 participant
@lohedges