Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd_response_protocol #1162

Closed
jmbell1989 opened this issue Mar 28, 2024 · 4 comments
Closed

cmd_response_protocol #1162

jmbell1989 opened this issue Mar 28, 2024 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation python Pull requests that update Python code question Questions about OpenC3

Comments

@jmbell1989
Copy link

I'm looking to create an interface that is a command response type interface with a crc at the end of the outgoing packets. I see there is now a cmd_response_protocol but no example usage. How do you define the packet response? Also I've tried to include the CRC helper protocol with no luck. Any help is appreciated!

@jmthomas jmthomas added question Questions about OpenC3 documentation Improvements or additions to documentation labels Mar 28, 2024
@jmthomas
Copy link
Member

We haven't really documented this well or converted our Demo over to the new syntax. I'll leave this open until we do. In the meantime it's basically something like this:

TELEMETRY TGT PKT BIG_ENDIAN "Handles the TLM command response"
  ACCESSOR TemplateAccessor # Default is <VALUE>
  TEMPLATE "<VOLTAGE>"
  APPEND_ITEM VOLTAGE 16 UINT

There is a 1 to 1 in the TEMPLATE with the items that are defined. You can change the template delimiters in the ACCESSOR line by doing something like: ACCESSOR TemplateAccessor ( ) to make it look for (VALUE).

@jmthomas
Copy link
Member

We also need to implement the python version of the cmd/response protocol

@jmbell1989
Copy link
Author

jmbell1989 commented Aug 2, 2024

@jmthomas Could you please provide and example of how the cmd would look as well as how I would include it in the plugin file? I'm guessing the cmd definition specifically calls out the associated telemetry item similar to the templated protocol

This may be off topic but I have a device that is solely cmd/response but doesn't have any sort of delimiter or sync chars. Will this still work or does the cmd/response expect a terminator?

@jmthomas jmthomas assigned jmthomas and unassigned ryanmelt Nov 13, 2024
@jmthomas jmthomas added the python Pull requests that update Python code label Nov 21, 2024
@jmthomas
Copy link
Member

jmthomas commented Dec 9, 2024

closed by #1684 and #1733

@jmthomas jmthomas closed this as completed Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Pull requests that update Python code question Questions about OpenC3
Projects
None yet
Development

No branches or pull requests

3 participants