Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read_conversion variable save to json #698

Open
MTI-GMays opened this issue Jun 13, 2023 · 1 comment
Open

Read_conversion variable save to json #698

MTI-GMays opened this issue Jun 13, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@MTI-GMays
Copy link

Is your feature request related to a problem? Please describe.
unable to output read conversion's passed function variable to json

Describe the solution you'd like
Add another variable like args_passed as a read attribute in conversion.rb to just a save the variable passed in to the function to json.

image

@jmthomas jmthomas added the enhancement New feature or request label Jun 15, 2023
@jmthomas
Copy link
Member

jmthomas commented Sep 2, 2024

It looks like accessor.rb is storing the args similar to this suggestion. Add @args to conversion, edit packet_item and packet_item_spec.rb::self.from_hash to ensure conversions can "round trip". May also have to modify packet_config.

Ensure changes across both Ruby and Python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants