Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Selinux #41

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Support Selinux #41

merged 1 commit into from
Aug 3, 2022

Conversation

ryanmelt
Copy link
Member

@ryanmelt ryanmelt commented Aug 3, 2022

Fixes Rootless podman for versions 5.0.5+ (and probably any linux with SELinux)

@ryanmelt ryanmelt requested a review from jmthomas August 3, 2022 03:35
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2022

Codecov Report

Merging #41 (2a0692d) into master (3443dbf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #41   +/-   ##
=======================================
  Coverage   77.86%   77.86%           
=======================================
  Files         238      238           
  Lines       18525    18525           
=======================================
  Hits        14424    14424           
  Misses       4101     4101           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the ‘:z’ doesn’t matter for other distros? What exactly does this do? Is there documentation you can link to?

@ryanmelt
Copy link
Member Author

ryanmelt commented Aug 3, 2022

The SELinux volume labels are discussed here:
https://docs.docker.com/storage/bind-mounts/#configure-the-selinux-label

@ryanmelt
Copy link
Member Author

ryanmelt commented Aug 3, 2022

I've tested on Mac and it still works correctly. I don't expect any problems on Windows Docker Desktop because it also runs on a linux VM.

@ryanmelt ryanmelt merged commit 56b6efa into master Aug 3, 2022
@ryanmelt ryanmelt deleted the handle_selinux_mounts branch August 3, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants