Screen autocomplete #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
==========================================
- Coverage 77.63% 76.80% -0.84%
==========================================
Files 238 29 -209
Lines 18644 1319 -17325
==========================================
- Hits 14475 1013 -13462
+ Misses 4169 306 -3863 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ryanmelt
approved these changes
Aug 25, 2022
| else | ||
| autocomplete_data = OpenC3::TargetModel.all(scope: scope).flat_map do |target_name, target_info| | ||
| OpenC3::TargetModel.packets(target_name, type: type.upcase.intern, scope: scope).flat_map do |packet| | ||
| packet_to_autocomplete_hashes(packet, target_info, type) |
There was a problem hiding this comment.
This isn't going to scale well to lots of packets.
There was a problem hiding this comment.
Worked ok for 1000 cmd packets generated by loadsim
| @@ -169,6 +171,9 @@ export default { | |||
| } | |||
| this.updateScreens() | |||
| }) | |||
| Api.get('/openc3-api/autocomplete/keywords/screen').then((response) => { | |||
| this.keywords = response.data | |||
There was a problem hiding this comment.
What about autocomplete for target,packet,item in valueWidgets?
There was a problem hiding this comment.
Yeah I punted on that for now. Might be a way to incorporate the existing stuff in there.
ryanmelt
requested changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #48