[frontend/backend] Migrate CK Editor to 9.3 (#8151) #8577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archidoit
changed the title
lndrtrbn
force-pushed
the
issue/3402-ckeditor-bump
branch
from
27225d7 to
6aa1c33
Compare
Archidoit
force-pushed
the
issue/3402-ckeditor-bump
branch
2 times, most recently
from
27225d7 to
cfddedf
Compare
labo-flg
force-pushed
the
release/6.4.0
branch
from
c0b3de1 to
8be7cd6
Compare
lndrtrbn
force-pushed
the
issue/3402-ckeditor-bump
branch
from
cfddedf to
41abcb1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/6.4.0 #8577 +/- ##
=================================================
+ Coverage 66.00% 66.02% +0.01%
=================================================
Files 606 606
Lines 61322 61322
Branches 6239 6245 +6
=================================================
+ Hits 40476 40486 +10
+ Misses 20846 20836 -10 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
lndrtrbn
reviewed
Oct 14, 2024
Comment on lines
+58
to
+86
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore | ||
| // eslint-disable-next-line import/extensions | ||
| import de from 'ckeditor5/translations/de.js'; | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore | ||
| // eslint-disable-next-line import/extensions | ||
| import en from 'ckeditor5/translations/en.js'; | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore | ||
| // eslint-disable-next-line import/extensions | ||
| import es from 'ckeditor5/translations/es.js'; | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore | ||
| // eslint-disable-next-line import/extensions | ||
| import fr from 'ckeditor5/translations/fr.js'; | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore | ||
| // eslint-disable-next-line import/extensions | ||
| import ja from 'ckeditor5/translations/ja.js'; | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore | ||
| // eslint-disable-next-line import/extensions | ||
| import ko from 'ckeditor5/translations/ko.js'; | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore | ||
| // eslint-disable-next-line import/extensions | ||
| import zh from 'ckeditor5/translations/zh.js'; |
There was a problem hiding this comment.
Yes, that's disgusting, I know 🤢 but cannot found a better way with how ckeditor is bundled...
lndrtrbn
force-pushed
the
issue/3402-ckeditor-bump
branch
from
5557724 to
4c0a82a
Compare
labo-flg
force-pushed
the
release/6.4.0
branch
2 times, most recently
from
c150d0f to
264e053
Compare
lndrtrbn
force-pushed
the
issue/3402-ckeditor-bump
branch
from
4c0a82a to
665dff9
Compare
Archidoit
added a commit
that referenced
this pull request
Nov 25, 2024
Archidoit
added
the
solved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Change the way we use CKEditor in OpenCTI.
Actual usage:
We have fetched a fix version of CKEditor and build a lib ourselves with the config we want to use it in our code.
New usage:
We fetch CKEditor from yarn as any other libs of the project and use it directly inside a new React component
CKEditorthat initiate the config to keep same behavior we had with the older build.The advantage of this is that it's easier to keep an up-to-date version of CKEditor.
Related issues