Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] add current user first in assignee/participant field (#4333) #8895

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

frapuks
Copy link
Member

@frapuks frapuks commented Nov 4, 2024

Proposed changes

  • add current user first in assignee/participant field

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

  • fix for the 2 cases : If the user is in the only 10 first results returned by the query AND if is not returned

@frapuks frapuks added the filigran team use to identify PR from the Filigran team label Nov 4, 2024
@frapuks frapuks self-assigned this Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.33%. Comparing base (3e0f5a7) to head (5f44727).
Report is 1 commits behind head on release/6.4.0.

Additional details and impacted files
@@              Coverage Diff               @@
##           release/6.4.0    #8895   +/-   ##
==============================================
  Coverage          64.33%   64.33%           
==============================================
  Files                608      608           
  Lines              58023    58023           
  Branches            6403     6404    +1     
==============================================
  Hits               37330    37330           
  Misses             20693    20693           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Archidoit
Copy link
Member

Behavior ok, working well, juste 2 code comments

@frapuks frapuks merged commit 00ce6a6 into release/6.4.0 Nov 4, 2024
5 checks passed
@frapuks frapuks deleted the issue/4333-fix2 branch November 4, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants