Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DCC Editor "Change Palette" cannot be closed by the window's X button #299

Open
bbrucee opened this issue Jun 4, 2021 · 1 comment · May be fixed by #312
Open

DCC Editor "Change Palette" cannot be closed by the window's X button #299

bbrucee opened this issue Jun 4, 2021 · 1 comment · May be fixed by #312

Comments

@bbrucee
Copy link
Contributor

bbrucee commented Jun 4, 2021 •
edited
Loading

Describe the bug

As title says, the DCC Editor "Change Palette" cannot be closed by the window's X button. When the X button is pressed the window closes but reopens

To Reproduce

Steps to reproduce the behavior:

  1. Open a DCC file
  2. Click on DCC Editor menu dropdown
  3. Select Change Palette
  4. Attempt to X out of the window

Expected behavior

Window closes with the behavior of "Don't use any palette" or "Exit"

Screenshots

If applicable, add screenshots to help explain your problem.

Animation
(Screen flickers in gif are from recording method going wrong, unrelated to the bug)
@bbrucee
Copy link
Contributor Author

bbrucee commented Jun 4, 2021

Stumbled on to this bug while investigating the DCC widget. It looks like it is caused by selectPalette boolean not being set to false when window is closed by the X button

https://github.com/OpenDiablo2/HellSpawner/blob/master/hswindow/hseditor/hsdcceditor/dcc_editor.go#L83

HellSpawner/hswidget/select_palette_widget.go

Line 45 in c07ca9a

closeCB: closeCB,
(closeCB does not fire)

@gucio321 gucio321 linked a pull request Jun 7, 2021 that will close this issue
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

hswidget/PaletteSelectWidget: refactor gucio321/HellSpawner
1 participant
@bbrucee